New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new implementation of MET corrections in PAT jetTools and start refactoring the MET uncertainty tool #4045
Conversation
A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X. use new implementation of CaloMET corrections in PAT jetTools It involves the following packages: PhysicsTools/PatAlgos @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks. |
I added a similar change for pfMET. Also I fixed a flaw, which was introduced when this commit 17f82ffa4902a was made. The change made in this commit wasn't properly propagated to PAT jetTools. |
In this branch, I started refactoring the MET uncertainty tool. In TaiSakuma@9dce9b2, I converted a method of the class RunMEtUncertainties, __propagateMEtUncertainties()_, to a function propagateMEtUncertainties(), and moved it to a new file, propagateMEtUncertainties.py because this method was not using any member variables of the class and was practically a function. I will continue to refactor the class RunMEtUncertainties. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
Use new implementation of MET corrections in PAT jetTools and start refactoring the MET uncertainty tool
This PR replaces the old implementation of CaloMET corrections in PAT jetTools with the new one.
We are preparing to delete the old implementation (#4014).
Incidentally, we plan to discontinue configuring MET corrections in jetTools. The plan was made a while ago (see slide2 https://indico.cern.ch/event/187209/contribution/3) but hasn't been implemented.