Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new implementation of MET corrections in PAT jetTools and start refactoring the MET uncertainty tool #4045

Merged
merged 5 commits into from Jun 16, 2014

Conversation

TaiSakuma
Copy link
Contributor

This PR replaces the old implementation of CaloMET corrections in PAT jetTools with the new one.

We are preparing to delete the old implementation (#4014).

Incidentally, we plan to discontinue configuring MET corrections in jetTools. The plan was made a while ago (see slide2 https://indico.cern.ch/event/187209/contribution/3) but hasn't been implemented.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X.

use new implementation of CaloMET corrections in PAT jetTools

It involves the following packages:

PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@TaiSakuma TaiSakuma changed the title use new implementation of CaloMET corrections in PAT jetTools use new implementation of MET corrections in PAT jetTools May 29, 2014
@cmsbuild
Copy link
Contributor

Pull request #4045 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@TaiSakuma
Copy link
Contributor Author

I added a similar change for pfMET.

Also I fixed a flaw, which was introduced when this commit 17f82ffa4902a was made. The change made in this commit wasn't properly propagated to PAT jetTools.

@cmsbuild
Copy link
Contributor

Pull request #4045 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@TaiSakuma TaiSakuma changed the title use new implementation of MET corrections in PAT jetTools use new implementation of MET corrections in PAT jetTools and start refactoring the MET uncertainty tool Jun 9, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2014

Pull request #4045 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@TaiSakuma
Copy link
Contributor Author

In this branch, I started refactoring the MET uncertainty tool.

In TaiSakuma@9dce9b2, I converted a method of the class RunMEtUncertainties, __propagateMEtUncertainties()_, to a function propagateMEtUncertainties(), and moved it to a new file, propagateMEtUncertainties.py because this method was not using any member variables of the class and was practically a function.

I will continue to refactor the class RunMEtUncertainties.
But please merge this PR while it is still mergeable.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Jun 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 16, 2014
Use new implementation of MET corrections in PAT jetTools and start refactoring the MET uncertainty tool
@ktf ktf merged commit d4e7d7a into cms-sw:CMSSW_7_2_X Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants