Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding HLT Configuration Proxy Support and Adding Tunnel Support : 13_X #40454

Merged
merged 3 commits into from Jan 9, 2023

Conversation

Sam-Harper
Copy link
Contributor

PR description:

This is the reopening of #40436 as I had to apply changes on top of existing 13_X changes thus one branch doesnt work for all now

From #40436
Confdb access is restricted to within the CERN network and thus for users outside CERN they must connect via tunnels.

Currently hltGetConfiguration and hltConfigFromDB allow the use of a socks proxy to allow users outside CERN to download menus. However the IPs need to be harcoded due to DNS issues (an issue with Java which as far as we are aware is unsolvable).

Only the offline DB had its IPs hardcoded, we now add IPs for the online (p5 only) and online mirror (accessable outside p5) so users can also use a proxy for these dbs.

Finally to have a work around in the future, support for direct tunnels where a user specifically forwards a given port on their machine to a db has been added so we can always fall back on this.

Aim to back port to 12_4, 12_5, 12_6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40454/33612

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Jan 9, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86f0b5/29837/summary.html
COMMIT: 2281f64
CMSSW: CMSSW_13_0_X_2023-01-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40454/29837/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 1217
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554299
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Jan 9, 2023

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit df24460 into cms-sw:master Jan 9, 2023
@missirol
Copy link
Contributor

@Sam-Harper , do you still plan to backport this PR down to 12_4_X ?

New 12_4_X and 12_6_X releases are expected soon, but maybe we could backport this PR in time for those.

I can also take care of the backports, if it helps.

@Sam-Harper
Copy link
Contributor Author

yes, sorry was at a workshop today, just prepping them now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants