Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T: Add jet quality and isolation data vs. emu comparisons and ignore object index #40472

Conversation

bundocka
Copy link
Contributor

PR description:

  • Adds jet quality and eg/tau isolation to the CaloL2 data vs emulator plots in the online DQM
  • Bug fix to ignore the ordering of CaloL2 objects for data vs emulator comparisons

PR validation:

  • Ran locally on lxplus with recent ExpressPhysics data and checked histogram outputs are as expected
  • Ran unit tests with cmsRun DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py unitTest=True

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bundocka for CMSSW_12_4_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)
  • DQM/L1TMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

@bundocka is this PR the backport of some other PR already merged or submitted to the master?
If not:

  • please make a PR for the master release first
  • what is the purpose of having this backported in 12_4_X?

@bundocka
Copy link
Contributor Author

@perrotta

I will close this since I see now we begin running in 2023 with 12_6_X

Thanks!

@bundocka bundocka closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants