Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[125X] Update realistic Heavy Ion MC GT #40473

Merged

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

This PR updates the realistic Heavy Ion MC GT (auto:phase1_2022_realistic_hi) with latest SiPixel bad component tags requested in this CMSTalk post [1]. More details for the request can be found in [2].

[1] https://cms-talk.web.cern.ch/t/125x-run-3-hi-gt-update-for-pixel-bad-components/19077
[2] https://cms-talk.web.cern.ch/t/request-alca-input-to-update-vertex-in-mc-of-2022-pbpb-test-run/18799/10

GT Difference
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022_realistic_HI_v7/125X_mcRun3_2022_realistic_HI_v8

PR validation:

Successfully ran:
runTheMatrix.py -l 159.0 -j10 --ibeos
which consumes the auto:phase1_2022_realistic_hi conditions.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This will soon be followed up by a forward port in master, once #40445 and #40464 are merged. No other backport expected,

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-984ec6/29900/summary.html
COMMIT: 594fb9f
CMSSW: CMSSW_12_5_X_2023-01-08-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40473/29900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 348 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3724047
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3723985
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 216 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

+alca

  • diffs in HI wf are expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6a1462a into cms-sw:CMSSW_12_5_X Jan 11, 2023
@perrotta
Copy link
Contributor

@saumyaphor4252 @tvami should these tags get updated also in the master GTs?

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

Yes, @saumyaphor4252 is working on it, I expect this to come in the coming hour.

@perrotta
Copy link
Contributor

backport of #40482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants