New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid use of auto:run*_data_relval
GTs in non-reHLT
wfs
#40481
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cms-sw/alca-l2
I need feedback from AlCa experts to finalise this PR.
I made this change assuming that the difference between
auto:run2_data
andauto:run2_data_relval
was only the L1T-Menu tag, but that assumption was wrong, as a few other tags are differenthttps://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun2_v2/124X_dataRun2_relval_v2
The different
EcalPedestals*
tags might explain the differences in DQM comparisons of wf1010.0
in the latest comparisons of this PR.Questions:
auto:X_relval
differs fromauto:X
only in the L1T-Menu tag(s) ?1010.0
) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @missirol
your assumption was correct, it seems to be a mistake from our predecessors. We will fix it. We are actually thinking about it to be a symbolic GT where it takes the
auto:X_relval
and adds the fix L1T-menu from the code.ALCAEXPTE
step is supposed to mimic express and do a PCL test. Thus it's the Express GT that should be consumed. Given that that key doesnt exists for Run-2, I'd go withauto:run2_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Thanks for the feedback!