Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding first version of electronics id class for HGCAL #40504

Merged
merged 2 commits into from Jan 20, 2023

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Jan 13, 2023

PR description:

When decoding or emulating realistic DIGI it may beneficial to include an intermediate Electronics ID.
This PR introduces such class to enable the developments on the logical mapping of HGCAL and on the raw data unpacker which are on-going. The class is a simple wrapper of a 32b word. The contents of which correspond to the following table/counting of entities.

image

PR validation:

A test unit is included in the PR and has been used to check the class holds and decodes the required values.
It can be run with

$CMSSW_BASE/test/$SCRAM_ARCH/HGCalElectronicsId [#repetitions] [verbosity level]

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40504/33701

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40504/33709

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for master.

It involves the following packages:

  • DataFormats/HGCalDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@trtomei, @missirol, @beaucero, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@pfs
Copy link
Contributor Author

pfs commented Jan 13, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98692f/29975/summary.html
COMMIT: fba0a43
CMSSW: CMSSW_13_0_X_2023-01-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40504/29975/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555513
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jan 14, 2023

+1

@srimanob
Copy link
Contributor

srimanob commented Jan 19, 2023

+Upgrade

FYI @cms-sw/hcal-dpg-l2 in case you have a comment.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 914e827 into cms-sw:master Jan 20, 2023
@pfs pfs deleted the hgc_elecid branch January 20, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants