Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEOMETRY] [CLANG] Fixes warnings reported by clang 14 #40509

Merged
merged 1 commit into from Jan 14, 2023
Merged

[GEOMETRY] [CLANG] Fixes warnings reported by clang 14 #40509

merged 1 commit into from Jan 14, 2023

Conversation

smuzaffar
Copy link
Contributor

This PR fixes the clang 14 warnings about

  • variable set but not used.
  • use of bitwise '&' with boolean operands

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jan 13, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40509/33706

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • Geometry/HcalTestBeamData (geometry)
  • Geometry/TrackerGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @ianna, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@VourMa, @JanFSchulte, @VinInn, @bsunanda, @mmusich, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

ianna
ianna reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

Geometry/HcalTestBeamData/plugins/DDEcalPreshowerAlgoTB.cc
@@ -138,7 +138,7 @@ void DDEcalPreshowerAlgoTB::doLayers(DDCompactView& cpv) {

void DDEcalPreshowerAlgoTB::doWedges(DDCompactView& cpv) {
LogDebug("HCalGeom") << "DDEcalPreshowerAlgoTB::debug : doWedges()";
int nx(0), ny(0), icopy(0), icopyt(0);
int icopy(0), icopyt(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar - thanks for looking into it. It looks like it is a legacy DDD. Is it the same in the DD4hep algorithms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianna , I think DD4Hep algorithms are fine, at least I do not see warnings from them in https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/el8_amd64_gcc11/www/thu/13.0.CLANG-thu-23/CMSSW_13_0_CLANG_X_2023-01-12-2300

ianna
ianna approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b71dc9/29970/summary.html
COMMIT: e40c147
CMSSW: CMSSW_13_0_X_2023-01-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40509/29970/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555513
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jan 14, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 27d7444 into cms-sw:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianna ianna ianna approved these changes

Assignees
No one assigned
Labels
code-checks-approved fully-signed geometry-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smuzaffar @cmsbuild @civanch @perrotta @ianna