fix SiStripApvGainsDefaultTrackerMap for clang 14

[mmusich]

PR description:

In response to #40518 (comment)

• should fix the clang 14 warnings variable set but not used for CondCore/SiStripPlugins

PR validation:

Run:

getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvGainsDefaultTrackerMap --tag SiStripApvGain_FromParticles_DecoMode_preVFP_v1_mc --input_params '{}' --time_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --db Prod --test

getPayloadData.py --plugin pluginSiStripApvGain_PayloadInspector --plot plot_SiStripApvGainsDefaultTrackerMap --tag SiStripApvGain_GR10_v1_hlt --input_params '{}' --time_type Run --iovs '{"start_iov": "359530", "end_iov": "359530"}' --db Prod --test ;

and obtained:

and

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40524/33731

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/SiStripPlugins/plugins/SiStripApvGain_PayloadInspector.cc modified in PR(s): [DB] [CLANG] Fixes warnings reported by clang 14 #40518

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/SiStripPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb08d2/29992/summary.html
COMMIT: b7f0ccb
CMSSW: CMSSW_13_0_X_2023-01-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40524/29992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.15 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555510
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1