[SIMULATION][CLANG] Fix warnings reported by clang 14 IB

[aandvalenzuela]

LLVM 14 based CLANG IBs show a lot of build warnings about use of bitwise operator instead of logical and definition of unused variables. This PR follows up #40242 to fix some of these warnings.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40533/33747

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h modified in PR(s): Include charge reweighting for Phase-2 IT planar sensors #40417

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40533/33747/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40533/33747/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40533/33749

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h modified in PR(s): Include charge reweighting for Phase-2 IT planar sensors #40417

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

• SimG4CMS/HcalTestBeam (simulation)
• SimG4CMS/ShowerLibraryProducer (simulation)
• SimMuon/RPCDigitizer (simulation)
• SimTracker/Common (simulation)
• SimTracker/TrackHistory (simulation)
• SimTransport/TotemRPProtonTransportParametrization (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @VourMa, @robervalwalsh, @bsunanda, @demuller, @threus, @slomeo, @JanFSchulte, @jhgoh, @dgulhan, @missirol, @prolay, @GiacomoSguazzoni, @rovere, @VinInn, @mmusich, @mtosi, @fabiocos, @AlexDeMoor, @AnnikaStein, @gbenelli, @JyothsnaKomaragiri, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aandvalenzuela]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c53e/30008/summary.html
COMMIT: d97eb2a
CMSSW: CMSSW_13_0_X_2023-01-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40533/30008/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.15 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555507
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

hold

• that qclust in the Charge Reweighting seems to be a pretty important quantity (cluster charge when the package does charge reweighting :P ) so it shouldnt be removed. I can look into this after 40417 is merged

[civanch]

@aandvalenzuela , for simplicity, may be it is possible to exclude SiPixelChargeReweightingAlgorithm from this PR and ask @tvami to clean-up the code?

[cmsbuild]

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[aandvalenzuela]

Hi @civanch, @tvami,
Yes, sure. Let's do this and I will open an issue to clean or actually use the qclust variable.

[tvami]

unhold

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40533/33761

• This PR adds an extra 8KB to repository

[cmsbuild]

Pull request #40533 was updated. @civanch, @mdhildreth can you please check and sign again.

[aandvalenzuela]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c53e/30015/summary.html
COMMIT: 38d44bf
CMSSW: CMSSW_13_0_X_2023-01-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40533/30015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.15 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555513
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1