Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize Alignment/OfflineValidation unit tests #40567

Merged
merged 3 commits into from Jan 19, 2023
Merged

Reorganize Alignment/OfflineValidation unit tests #40567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d3cda7
re-organize Alignment/OfflineValidation unit test
mmusich Jan 11, 2023
6cfc315
reduce verbosity of GeometryComparisonPlotter
mmusich Jan 18, 2023
87d68c4
update number of events in the PV-related unit tests
mmusich Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/src/GeometryComparisonPlotter.cc
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
// NOTE: look for "TO DO" as a keyword to now what should be upgraded in later versions....

// modes
#define TALKATIVE // get some comments while processing
//#define TALKATIVE // get some comments while processing
//#define DEBUG // get a lot of comments while processing + canvases -> resource-consuming!

// MACROS
Expand Down
22 changes: 11 additions & 11 deletions Alignment/OfflineValidation/test/BuildFile.xml
View file
Open in desktop
@@ -1,34 +1,34 @@
<environment>
<bin file="testAlignmentOfflineValidation.cpp" name="validateAlignments">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test validateAlignments.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/validateAlignments.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="DMRall">
<flags PRE_TEST="validateAlignments"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitDMR.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitDMR.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="PVall">
<flags PRE_TEST="validateAlignments"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitPV.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitPV.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="SplitVall">
<flags PRE_TEST="validateAlignments"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitSplitV.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitSplitV.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="GCPall">
<flags PRE_TEST="validateAlignments"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitGCP.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitGCP.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testTrackAnalyzers.cc" name="testTrackAnalysis">
<use name="FWCore/TestProcessor"/>
<use name="catch2"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="GeneralTrackAnalyser">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitGeneralTrackAnalyser.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitGeneralTrackAnalyser.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testPVPlotting.cpp" name="testPVPlotting">
Expand All @@ -39,19 +39,19 @@
<use name="Alignment/OfflineValidation"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="DiMuonVertex">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitDiMuonVertex.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitDiMuonVertex.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="SubmitPVrbr">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitSubmitPVrbr.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitSubmitPVrbr.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="SubmitPVsplit">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitSubmitPVsplit.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitSubmitPVsplit.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="EoP">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitEoP.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitEoP.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<bin file="testEoPPlotting.cpp" name="testEoPPlotting">
Expand All @@ -62,7 +62,7 @@
<use name="Alignment/OfflineValidation"/>
</bin>
<bin file="testAlignmentOfflineValidation.cpp" name="Miscellanea">
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test test_unitMiscellanea.sh"/>
<flags TEST_RUNNER_ARGS=" /bin/bash Alignment/OfflineValidation/test testingScripts/test_unitMiscellanea.sh"/>
<use name="FWCore/Utilities"/>
</bin>
</environment>
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/test/test_all_Phase2_cfg.py
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ class RefitType(Enum):

runboundary = 1
process.source.firstRun = cms.untracked.uint32(int(runboundary))
process.maxEvents = cms.untracked.PSet( input = cms.untracked.int32(10) )
process.maxEvents = cms.untracked.PSet( input = cms.untracked.int32(100) )

###################################################################
# JSON Filtering
Expand Down
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/test/test_all_cfg.py
View file
Open in desktop
Expand Up @@ -32,7 +32,7 @@ class RefitType(Enum):

runboundary = 1
process.source.firstRun = cms.untracked.uint32(int(runboundary))
process.maxEvents = cms.untracked.PSet( input = cms.untracked.int32(2600) )
process.maxEvents = cms.untracked.PSet( input = cms.untracked.int32(100) )

###################################################################
# JSON Filtering
Expand Down
0 ...fflineValidation/test/testPVValidation.sh → ...n/test/testingScripts/testPVValidation.sh
View file
Open in desktop
File renamed without changes.
0 ...OfflineValidation/test/test_all-in-one.sh → ...on/test/testingScripts/test_all-in-one.sh
View file
Open in desktop
File renamed without changes.
0 ...nt/OfflineValidation/test/test_unitDMR.sh → ...ation/test/testingScripts/test_unitDMR.sh
View file
Open in desktop
File renamed without changes.
0 ...eValidation/test/test_unitDiMuonVertex.sh → ...t/testingScripts/test_unitDiMuonVertex.sh
View file
Open in desktop
File renamed without changes.
0 ...nt/OfflineValidation/test/test_unitEoP.sh → ...ation/test/testingScripts/test_unitEoP.sh
View file
Open in desktop
File renamed without changes.
0 ...nt/OfflineValidation/test/test_unitGCP.sh → ...ation/test/testingScripts/test_unitGCP.sh
View file
Open in desktop
File renamed without changes.
0 ...ion/test/test_unitGeneralTrackAnalyser.sh → ...gScripts/test_unitGeneralTrackAnalyser.sh
View file
Open in desktop
File renamed without changes.
0 ...neValidation/test/test_unitMiscellanea.sh → ...st/testingScripts/test_unitMiscellanea.sh
View file
Open in desktop
File renamed without changes.
0 ...ent/OfflineValidation/test/test_unitPV.sh → ...dation/test/testingScripts/test_unitPV.sh
View file
Open in desktop
File renamed without changes.
0 ...OfflineValidation/test/test_unitSplitV.sh → ...on/test/testingScripts/test_unitSplitV.sh
View file
Open in desktop
File renamed without changes.
0 ...neValidation/test/test_unitSubmitPVrbr.sh → ...st/testingScripts/test_unitSubmitPVrbr.sh
View file
Open in desktop
File renamed without changes.
0 ...Validation/test/test_unitSubmitPVsplit.sh → .../testingScripts/test_unitSubmitPVsplit.sh
View file
Open in desktop
File renamed without changes.
0 ...lineValidation/test/validateAlignments.sh → ...test/testingScripts/validateAlignments.sh
View file
Open in desktop
File renamed without changes.