Phase2-hgx335C Extend testing of the V16/V17 geometry versions of HGCal

[bsunanda]

PR description:

Extend testing of the V16/V17 geometry versions of HGCal. These tests are not expected to produce changes in any existing scenarios

PR validation:

Use these testing tools to make more elaborate tests of HGCal geometries (V17 and V16)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40573/33817

• This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40573/33817/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40573/33817/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40573/33819

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• SimG4CMS/Calo (simulation)
• Validation/HGCalValidation (dqm)

@civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @fabiocos, @lecriste, @sethzenz, @missirol, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @pfs, @thomreis, @hatakeyamak, @trtomei, @ebrondol, @beaucero, @slomeo, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0414c7/30089/summary.html
COMMIT: 4d88e29
CMSSW: CMSSW_13_0_X_2023-01-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40573/30089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555479
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555454
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@emanueleusai @srimanob Please approve this PR

[emanueleusai]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1