Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Hgg trkSumPtHollowConeDR03 variable in NanoAOD #40583

Merged

Conversation

VourMa
Copy link
Contributor

@VourMa VourMa commented Jan 20, 2023

This PR is a follow-up to a couple of updates made to the NanoAOD content to accommodate variables that are needed for the preselection of H -> γγ analyses.

PRs #36037 and #36526 applied the changes advertized in an XPOG meeting presentation some time ago. The variable trkSumPtHollowConeDR03 is mentioned in the slides but was included neither in the aforementioned PRs nor in a subsequent one. After a communication with the XPOG conveners, the Hgg conveners and the authors of the previous relevant PRs, this PR comes to include this variable.

As a simple validation, a custom NanoAOD file was produced with the updated configuration and it included the new branch with reasonable values.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40583/33835

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VourMa (Manos Vourliotis) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Jan 21, 2023

enable nano

@swertz
Copy link
Contributor

swertz commented Jan 21, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-415fa9/30113/summary.html
COMMIT: 2caaee0
CMSSW: CMSSW_13_0_X_2023-01-21-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40583/30113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555479
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.169000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.897 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.445 KiB Physics/NanoAODDQM
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 10813
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 10813
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.162000000000001 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): 0.897 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.331,... ): 0.445 KiB Physics/NanoAODDQM
  • Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.232 2.229 0.003 ( +0.1% ) 9.73 9.58 +1.6% 1.524 1.475
2500.311 2.323 2.319 0.004 ( +0.2% ) 9.40 9.22 +1.9% 1.893 1.835
2500.312 2.277 2.273 0.004 ( +0.2% ) 9.47 9.35 +1.3% 1.884 1.830
2500.33 1.098 1.095 0.003 ( +0.2% ) 22.14 21.81 +1.5% 1.650 1.644
2500.331 1.393 1.390 0.003 ( +0.2% ) 15.90 15.96 -0.4% 1.800 1.799
2500.332 1.324 1.321 0.003 ( +0.2% ) 18.16 17.82 +1.9% 1.855 1.857
2500.401 2.138 2.135 0.003 ( +0.2% ) 10.46 10.35 +1.1% 1.217 1.160
2500.501 1.711 1.708 0.003 ( +0.2% ) 16.39 16.58 -1.1% 1.135 1.098
2500.511 1.123 1.120 0.002 ( +0.2% ) 31.24 30.54 +2.3% 1.379 1.336
2500.601 2.050 2.048 0.002 ( +0.1% ) 12.59 12.50 +0.7% 1.203 1.141

@swertz
Copy link
Contributor

swertz commented Jan 23, 2023

+1

New variable visible in DQM and looks reasonable.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cd64406 into cms-sw:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants