BeamSpot + Rho variables in nanoAODs #36037

maxgalli · 2021-11-08T15:28:18Z

PR description:

This PR introduces the photon variables required to allow H->gamma gamma to move to nanoAODs.
The changes were discussed in this XPOG meeting.

EDIT

The photons related variables were moved to #36526

cmsbuild · 2021-11-08T15:34:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36037/26493

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/NanoAOD/src/classes_def.xml modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/interface/SimpleFlatTableProducer.h modified in PR(s): Storing Generator Filter Information in NanoAOD #34169
- File PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc modified in PR(s): Storing Generator Filter Information in NanoAOD #34169
- File PhysicsTools/NanoAOD/plugins/TableOutputBranches.cc modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/plugins/TableOutputBranches.h modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/globals_cff.py modified in PR(s): Storing Generator Filter Information in NanoAOD #34169

cmsbuild · 2021-11-08T15:34:59Z

A new Pull Request was created by @maxgalli (Massimiliano Galli) for master.

It involves the following packages:

DataFormats/NanoAOD (xpog)
PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @rovere, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2021-11-08T15:35:53Z

please test

cmsbuild · 2021-11-08T16:20:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36037/26495

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/NanoAOD/src/classes_def.xml modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/interface/SimpleFlatTableProducer.h modified in PR(s): Storing Generator Filter Information in NanoAOD #34169
- File PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc modified in PR(s): Storing Generator Filter Information in NanoAOD #34169
- File PhysicsTools/NanoAOD/plugins/TableOutputBranches.cc modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/plugins/TableOutputBranches.h modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/globals_cff.py modified in PR(s): Storing Generator Filter Information in NanoAOD #34169

cmsbuild · 2021-11-08T16:20:57Z

Pull request #36037 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

gouskos · 2021-11-08T16:26:26Z

please test

cmsbuild · 2021-11-08T17:54:55Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fdc3b/20341/summary.html
COMMIT: 351ebb1
CMSSW: CMSSW_12_2_X_2021-11-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36037/20341/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.911

----- Begin Fatal Exception 08-Nov-2021 18:07:45 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'EcalBarrelGeometryEPdd4hep' in category 'CMS EDM Framework ParameterSet Description'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

mariadalfonso · 2021-11-09T16:44:18Z

please test

cmsbuild · 2022-02-11T10:07:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36037/28264

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/NanoAOD/src/classes_def.xml modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/plugins/TableOutputBranches.cc modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/plugins/TableOutputBranches.h modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Hgg photons variables in nanoAODs #36526
- File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): NANOAOD: simplify configuration #36845, Hgg photons variables in nanoAODs #36526

cmsbuild · 2022-02-11T10:07:24Z

Pull request #36037 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2022-02-11T10:28:54Z

please test

cmsbuild · 2022-02-11T14:49:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fdc3b/22349/summary.html
COMMIT: c317073
CMSSW: CMSSW_12_3_X_2022-02-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36037/22349/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@adewit Phase2 tracker: add T30 (geometry with more realistic TFPX) #36660
@bsunanda Run3-alca216Y To make the response study work without HLT information if needed #36912
@makortel Add option in IgProfService to dump profiles at {pre,post}ModuleEvent #36923

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fdc3b/22349/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fdc3b/22349/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764395
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3764371
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 7.296 KiB( 45 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.912 KiB Physics/NanoAODDQM
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

mariadalfonso · 2022-02-11T15:47:29Z

Beam Spot added and reorganised the Rho block while adding one more float.

size increase negligible

Reco comparison results: 12 differences found in the comparisons

these differences are now related to the objects touched by this PR. Previous difference reported in earlier tests were related to the change in the enums order

mariadalfonso · 2022-02-11T15:48:51Z

+xpog

changes as expected on BeanSpot and Rho

cmsbuild · 2022-02-11T15:49:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-11T19:02:45Z

+1

New variables added to nanoAod output

cmsbuild added this to the CMSSW_12_2_X milestone Nov 8, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Nov 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 8, 2021

cmsbuild added tests-started code-checks-pending tests-pending and removed tests-pending tests-started code-checks-approved labels Nov 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 8, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 8, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 8, 2021

cmsbuild added tests-started and removed tests-rejected labels Nov 9, 2021

maxgalli force-pushed the hgg_photons2 branch from 180ea59 to c317073 Compare February 11, 2022 09:59

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 11, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 11, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 11, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 11, 2022

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 11, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 11, 2022

cmsbuild merged commit 29eb421 into cms-sw:master Feb 11, 2022

This was referenced Feb 12, 2022

Add 2021 MinimumBias express and prompt reco wf to limited #36942

Merged

Update Run-3 data and MC GTs with several updates #36940

Merged

slava77 mentioned this pull request May 17, 2022

reco comparisons: updated maps and monitoring for new products cms-sw/cms-bot#1762

Merged

perrotta mentioned this pull request Jan 13, 2023

Nano: fix array size branch type, support 16 bit ints, use more 8 or 16 bit integers #40478

Merged

perrotta mentioned this pull request Jan 20, 2023

Remove a seemingly useless vector definition #40579

Merged

VourMa mentioned this pull request Jan 20, 2023

Addition of Hgg trkSumPtHollowConeDR03 variable in NanoAOD #40583

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BeamSpot + Rho variables in nanoAODs #36037

BeamSpot + Rho variables in nanoAODs #36037

maxgalli commented Nov 8, 2021 •

edited

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

mariadalfonso commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

gouskos commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

mariadalfonso commented Nov 9, 2021

cmsbuild commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

mariadalfonso commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

mariadalfonso commented Feb 11, 2022 •

edited

mariadalfonso commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

perrotta commented Feb 11, 2022

BeamSpot + Rho variables in nanoAODs #36037

BeamSpot + Rho variables in nanoAODs #36037

Conversation

maxgalli commented Nov 8, 2021 • edited

PR description:

EDIT

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

mariadalfonso commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

gouskos commented Nov 8, 2021

cmsbuild commented Nov 8, 2021

RelVals

mariadalfonso commented Nov 9, 2021

cmsbuild commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

mariadalfonso commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

Comparison Summary

mariadalfonso commented Feb 11, 2022 • edited

mariadalfonso commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

perrotta commented Feb 11, 2022

maxgalli commented Nov 8, 2021 •

edited

mariadalfonso commented Feb 11, 2022 •

edited