New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TrackerAdditionalParametersPerDet_cfi from SiStripCommon unit test #40584
Remove TrackerAdditionalParametersPerDet_cfi from SiStripCommon unit test #40584
Conversation
type bugfix |
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40584/33836
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
hi @cms-sw/orp-l2
the relevant unit tests have passed, is there any point in waiting for the relvals to finish? also given the simplicity of the PR, I'm wondering if we need to wait for the |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295825/30110/summary.html Comparison SummarySummary:
|
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Follow-up to #40443 (comment)
As the title says: removed TrackerAdditionalParametersPerDet_cfi from SiStripCommon unit test
PR validation:
scram b runtests
is successful`If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, no backport is needed