Phase2-hgx335E Update the validity test of partial wafers of V16 geometry as well as the test kits

[bsunanda]

PR description:

Update the validity test of partial wafers of V16 geometry as well as the test kits. Expect small changes in all scenarios using V16 geometry of HGCal or HFNose

PR validation:

Use the test scripts in Geometry/HGCalCommonData/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing sp[ecial

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40585/33840

• This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40585/33840/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40585/33840/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40585/33842

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b09217/30116/summary.html
COMMIT: 880f528
CMSSW: CMSSW_13_0_X_2023-01-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40585/30116/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11781 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555479
• DQMHistoTests: Total failures: 6439
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3549016
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: found differences in 3 / 47 workflows

[bsunanda]

+geometry

[srimanob]

Hi @bsunanda
I assume we don't expect the change from this PR. The PR test shows the change in Phase-2 workflow, https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_0_X_2023-01-22-2300+b09217/55138/validateJR.html. Should we re-trigger the test?

[bsunanda]

@srimanob Since the validity test is modified for v16, we expect to see some changes in Phase2 scenarios

[srimanob]

+Upgrade

Change in D88 is expected as mentioned in the PR description and #40585 (comment). Thx @bsunanda

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1