Phase2-hgx335J Try to add toplogy class for HGCal TB application #40603
Conversation
|
@Dr15Jones, @makortel How can I avoid the type lookup error? I am not |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40603/33860
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@bsunanda Can you give more details of the error? |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40603/33861
|
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
At the time of scram build it reports:
> Building shared library tmp/slc7_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/libGeometryCaloTopology.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02769/slc7_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/HGCalTBTopology.cc.o: in function `std::type_info const& edm::typelookup::classTypeInfo<HGCalTBTopology>()':
HGCalTBTopology.cc:(.text+0x1f3): undefined reference to `typeinfo for HGCalTBTopology'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02769/slc7_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/HGCalTBTopology.cc.o: in function `HGCalTBTopology::HGCalTBTopology(HGCalTBDDDConstants const&, int)':
HGCalTBTopology.cc:(.text+0x467): undefined reference to `vtable for HGCalTBTopology'
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02769/slc7_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/HGCalTBTopology.cc.o: in function `_GLOBAL__sub_I_HGCalTBTopology.cc':
HGCalTBTopology.cc:(.text.startup+0xee): undefined reference to `typeinfo for HGCalTBTopology'
collect2: error: ld returned 1 exit status
gmake: *** [config/SCRAM/GMake/Makefile.rules:1717: tmp/slc7_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/libGeometryCaloTopology.so] Error 1
gmake: *** Waiting for unfinished jobs....
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
…________________________________
From: cmsbuild ***@***.***
Sent: 24 January 2023 18:02
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Phase2-hgx335J Try to add toplogy class for HGCal TB application (PR #40603)
A new Pull Request was created by @bsunanda<https://github.com/bsunanda> (Sunanda Banerjee) for master.
It involves the following packages:
* Geometry/CaloTopology (geometry)
@civanch<https://github.com/civanch>, @Dr15Jones<https://github.com/Dr15Jones>, @makortel<https://github.com/makortel>, @mdhildreth<https://github.com/mdhildreth>, @cmsbuild<https://github.com/cmsbuild>, @bsunanda<https://github.com/bsunanda> can you please review it and eventually sign? Thanks.
@simonepigazzini<https://github.com/simonepigazzini>, @fabiocos<https://github.com/fabiocos>, @thomreis<https://github.com/thomreis> this is something you requested to watch as well.
@perrotta<https://github.com/perrotta>, @dpiparo<https://github.com/dpiparo>, @rappoccio<https://github.com/rappoccio> you are the release manager for this.
cms-bot commands are listed here<http://cms-sw.github.io/cms-bot-cmssw-cmds.html>
—
Reply to this email directly, view it on GitHub<#40603 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORGQMWGTNWG5OLBSATWUADL3ANCNFSM6AAAAAAUFKBBLI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@makortel @Dr15Jones I have added what message I get during building the library. Please take a look at the previous entry in his PR |
|
@cmsbuild, please test Hmm, not immediately clear. Let's see if it reproduces here. |
cmsbuild
added
tests-started
tests-rejected
and removed
tests-pending
tests-started
labels
|
-1 Failed Tests: Build BuildI found compilation error when building: HGCalTBTopology.cc:(.text+0x1f3): undefined reference to `typeinfo for HGCalTBTopology' /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02769/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: tmp/el8_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/HGCalTBTopology.cc.o: in function `HGCalTBTopology::HGCalTBTopology(HGCalTBDDDConstants const&, int)': HGCalTBTopology.cc:(.text+0x467): undefined reference to `vtable for HGCalTBTopology' /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02769/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: tmp/el8_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/HGCalTBTopology.cc.o: in function `_GLOBAL__sub_I_HGCalTBTopology.cc': HGCalTBTopology.cc:(.text.startup+0xee): undefined reference to `typeinfo for HGCalTBTopology' collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_amd64_gcc11/src/Geometry/CaloTopology/src/GeometryCaloTopology/libGeometryCaloTopology.so] Error 1 Leaving library rule at Geometry/CaloTopology Entering library rule at src/Geometry/CaloTopology/test >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-24-2300/src/Geometry/CaloTopology/test/CaloTowerMapTester.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_X_2023-01-24-2300/src/Geometry/CaloTopology/test/CaloTowerTopologyTester.cc |
| HGCalTBTopology(const HGCalTBDDDConstants& hdcons, int subdet); | ||
|
|
||
| /// virtual destructor | ||
| ~HGCalTBTopology() override = default; |
There was a problem hiding this comment.
Try removing this line and see if that helps the linking problem.
There was a problem hiding this comment.
I removed the destructor and it still gives the same error. Does it need a default constructor?
There was a problem hiding this comment.
That didn't help either
|
@cmsbuild Please test |
|
-1 Failed Tests: UnitTests RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test testTriggerMonitors had ERRORS RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
|
@cmsbuild Please test |
1 similar comment
|
@cmsbuild Please test |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d4182/30217/summary.html Comparison SummarySummary:
|
|
+geometry |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Try to add toplogy class for HGCal TB application
PR validation:
Not fully tested. Need suggestion how to avoid type lookup error. Then add the topology builder and test it
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing. special