[RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611

aandvalenzuela · 2023-01-25T13:26:12Z

Hello,

This PR fixes the warnings due to unused but set variables and the use of bitwise '|' or '&' with boolean operands that we get with LLVM14 in CLANG IBs for the reconstruction modules.

Thanks,
Andrea.

cmsbuild · 2023-01-25T13:37:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40611/33874

This PR adds an extra 84KB to repository

cmsbuild · 2023-01-25T13:37:36Z

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

CommonTools/RecoAlgos (reconstruction)
RecoHI/HiJetAlgos (reconstruction)
RecoJets/JetProducers (reconstruction)
RecoLocalCalo/HcalRecAlgos (reconstruction)
RecoLocalMuon/DTSegment (reconstruction)
RecoLocalTracker/SiPixelClusterizer (reconstruction)
RecoLocalTracker/SiPixelRecHits (reconstruction)
RecoParticleFlow/PFClusterProducer (reconstruction)
RecoPixelVertexing/PixelTriplets (reconstruction)
RecoTracker/CkfPattern (reconstruction)
RecoTracker/FinalTrackSelectors (reconstruction)
RecoTracker/MeasurementDet (reconstruction)
RecoTracker/TkSeedingLayers (reconstruction)
RecoTracker/TransientTrackingRecHit (reconstruction)
TrackingTools/DetLayers (reconstruction)
TrackingTools/GsfTools (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @VourMa, @yslai, @felicepantaleo, @hatakeyamak, @argiro, @bsunanda, @thomreis, @threus, @mmusich, @seemasharmafnal, @youyingli, @mmarionncern, @missirol, @ahinzmann, @mtosi, @JanFSchulte, @jhgoh, @lgray, @apsallid, @yenjie, @ferencek, @mandrenguyen, @yetkinyilmaz, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @bellan, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @abdoulline, @dgulhan, @clelange, @simonepigazzini, @jdamgov, @jdolen, @rchatter, @battibass, @jazzitup, @dkotlins, @kurtejung, @gpetruc, @mariadalfonso, @sameasy, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aandvalenzuela · 2023-01-25T13:38:41Z

please test

RecoPixelVertexing/PixelTriplets/plugins/PixelTripletLargeTipGenerator.cc

slava77 · 2023-01-25T14:27:31Z

TrackingTools/GsfTools/interface/CloseComponentsMerger.icc

@@ -73,7 +73,7 @@ MultiGaussianState<N> CloseComponentsMerger<N>::merge(const MultiState& mgs) con
      comp.push_back(ori[toMerge.top()]);
      comp.push_back(ori[ii]);
      active[ii] = false;
-      while ((!toMerge.empty()) & (!active[toMerge.top()])) {
+      while ((!toMerge.empty()) && (!active[toMerge.top()])) {


I guess here it should be a logical && to avoid out of bound reads
@VinInn please confirm/check

cmsbuild · 2023-01-25T16:49:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71c36a/30162/summary.html
COMMIT: afaf7a4
CMSSW: CMSSW_13_0_X_2023-01-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40611/30162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-01-27T10:21:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40611/33910

This PR adds an extra 8KB to repository

cmsbuild · 2023-01-27T10:21:55Z

Pull request #40611 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

TrackingTools/DetLayers/interface/rangesIntersect.h

Fix clang llvm14 warnings Keep intended bitwise operator Keep intended bitwise operator

cmsbuild · 2023-01-31T08:36:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40611/33949

This PR adds an extra 76KB to repository

cmsbuild · 2023-01-31T08:36:52Z

Pull request #40611 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

clacaputo · 2023-02-03T10:39:22Z

please test

cmsbuild · 2023-02-03T13:30:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71c36a/30378/summary.html
COMMIT: 26664b3
CMSSW: CMSSW_13_0_X_2023-02-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40611/30378/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555467
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

clacaputo · 2023-02-07T14:56:50Z

+reconstruction

cmsbuild · 2023-02-07T14:57:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-02-07T15:20:30Z

+1

cmsbuild added this to the CMSSW_13_0_X milestone Jan 25, 2023

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending tracking trk labels Jan 25, 2023

aandvalenzuela changed the title ~~Fix clang llvm14 warnings~~ [RECONSTRUCTION][CLANG] Fix clang llvm14 warnings Jan 25, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 25, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 25, 2023

slava77 reviewed Jan 25, 2023

View reviewed changes

RecoPixelVertexing/PixelTriplets/plugins/PixelTripletLargeTipGenerator.cc Outdated Show resolved Hide resolved

slava77 reviewed Jan 25, 2023

View reviewed changes

cmsbuild added tests-approved code-checks-pending tests-pending and removed tests-started tests-approved code-checks-approved labels Jan 25, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 27, 2023

slava77 reviewed Jan 27, 2023

View reviewed changes

TrackingTools/DetLayers/interface/rangesIntersect.h Outdated Show resolved Hide resolved

Fix clang llvm14 warnings

26664b3

Fix clang llvm14 warnings Keep intended bitwise operator Keep intended bitwise operator

aandvalenzuela force-pushed the reco-clang-warnings branch from 2521193 to 26664b3 Compare January 31, 2023 08:28

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 31, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2023

cmsbuild mentioned this pull request Jan 31, 2023

remove duplicate plugins left by #38761 and #40264 #40646

Merged

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 7, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2023

cmsbuild merged commit b6ecba4 into cms-sw:master Feb 7, 2023

This was referenced Feb 7, 2023

[Tensorflow] Build with GPU enabled cms-sw/cmsdist#7648

Merged

Update Tensorflow to version 2.11.0 cms-sw/cmsdist#8258

Closed

[BuildRules] Enable alpaka/rocm backend and fix lto edm plugins cms-sw/cmsdist#8298

Closed

slava77 mentioned this pull request Feb 16, 2023

Change bit operation to logical operation in TrackingTools/DetLayers #40799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611

[RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611

aandvalenzuela commented Jan 25, 2023 •

edited

cmsbuild commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

aandvalenzuela commented Jan 25, 2023

slava77 Jan 25, 2023

cmsbuild commented Jan 25, 2023

cmsbuild commented Jan 27, 2023

cmsbuild commented Jan 27, 2023

cmsbuild commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

clacaputo commented Feb 3, 2023

cmsbuild commented Feb 3, 2023

clacaputo commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

perrotta commented Feb 7, 2023

[RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611

[RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611

Conversation

aandvalenzuela commented Jan 25, 2023 • edited

cmsbuild commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

aandvalenzuela commented Jan 25, 2023

slava77 Jan 25, 2023

Choose a reason for hiding this comment

cmsbuild commented Jan 25, 2023

Comparison Summary

cmsbuild commented Jan 27, 2023

cmsbuild commented Jan 27, 2023

cmsbuild commented Jan 31, 2023

cmsbuild commented Jan 31, 2023

clacaputo commented Feb 3, 2023

cmsbuild commented Feb 3, 2023

Comparison Summary

clacaputo commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

perrotta commented Feb 7, 2023

aandvalenzuela commented Jan 25, 2023 •

edited