[Alignment/OfflineValidation] restructure the primary-vertex related unit tests

[mmusich]

PR description:

In (partial) response of the #40567 (comment):

• further lowering down the amount of event used in the phase-2 flavor of unit test (from 100 to 10)
• merge phase-1 and phase-2 test configurations in the same file
• rename the unit test to be more descriptive

PR validation:

Run successfully scram b runtests_PrimaryVertex

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40612/33877

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

thanks @mmusich for looking in to it. We also noticed that test was reading a 90GB large file (root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_5_3/RelValMinBias_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v5_2026D88PU-v1/2590000/22e22ae6-a353-4f2e-815e-cc5efee37af9.root ) and job just hands after printing

Begin processing the 1st record. Run 1, Event 6602, LumiSection 67 on stream 1 at 25-Jan-2023 16:38:50.763 CET

I guess it is waiting for input file to be available and then we get message like

[2023-01-25 15:50:00.751186 +0100][Error  ][PostMaster        ] [eoscms.cern.ch:1094] Forcing error on disconnect: [ERROR] Operation interrupted.

could this large file be the issue here?

[mmusich]

@cmsbuild, please test

[mmusich]

could this large file be the issue here?

I am not sure in what sense the size the can be an issue here, excepted that since this is a PU=200 MC sample the computation will be on the heavy side. On the other hand I am planning to move to a (lighter) ALCARECO sample, once that's available (should be for the next pre-release, as it needs #40548 to be processed correctly)

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d946a/30169/summary.html
COMMIT: bc37318
CMSSW: CMSSW_13_0_X_2023-01-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40612/30169/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testPVPlotting had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555470
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40612/33888

• This PR adds an extra 16KB to repository

[mmusich]

@cmsbuild, please test

[smuzaffar]

ah ok, I thought test was still using [a].

[a]

[muzaffar@lxplus768 ~]$ ls -lh /eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_5_3/RelValMinBias_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v5_2026D88PU-v1/2590000/22e22ae6-a353-4f2e-815e-cc5efee37af9.root 
-rw-r--r--. 1 cmsbuild zh 91G Jan 26 11:42 /eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_5_3/RelValMinBias_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v5_2026D88PU-v1/2590000/22e22ae6-a353-4f2e-815e-cc5efee37af9.root

[cmsbuild]

Pull request #40612 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[mmusich]

ah ok, I thought test was still using [a].

yes, it's still using that, but it's another test (the one that now doesn't fail anymore)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40612/33896

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #40612 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[mmusich]

@cmsbuild, please test for el8_aarch64_gcc11

in the last push I reduced the input file size also for the phase-2 test:

$ eos ls -lh /store/relval/CMSSW_12_6_0_pre5/RelValTTbar_14TeV/GEN-SIM-RECO/125X_mcRun4_realistic_v5_2026D88noPU-v1/2590000/57cbe250-487d-4a47-998b-48f9028a0058.root
-rw-r--r--   2 cmsprd   zh             5.94 G Dec  5 21:37 57cbe250-487d-4a47-998b-48f9028a0058.root

lets' see how it goes

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d946a/30192/summary.html
COMMIT: ccbb2d8
CMSSW: CMSSW_13_0_X_2023-01-25-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40612/30192/install.sh to create a dev area with all the needed externals and cmssw changes.

[mmusich]

unit tests look good now

[tvami]

+alca

• tests pass for el8_aarch64_gcc11 as well now

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

thanks a lot @mmusich. Indeed tests look good now. Test were run on the slowest arm node and finished with in time limits.

[perrotta]

+1