Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport codes for adding new data catalogs from Rucio storage description (RucioCatalog) and use it by default instead of trivial data catalogs (TrivialCatalog) #37278, and related bug fixes #40628

Closed
wants to merge 384 commits into from

Conversation

nhduongvn
Copy link
Contributor

PR description:

Backport to 12_5_X:
#37278
#39314
#39727

valsdav and others added 30 commits September 26, 2022 23:40
Fixed misnamed files in EcalTPG unittest script
…PutProduct_125x

[12_5_X] Release dependent modules only after the worker has finished for scheduled modules
…_fit_12_5

[12_5_X] Add calibration fit plot to the PPS HPTDC PCL
…ConditionalTask modules in Path

If the EDAlias has wildcards for one module, and more specific aliases
for another module, we should use the one that has the most
constrained match. There is one ambiguous case left, for which an
exception is thrown. I hope we won't encounter that situation in
practice.

The problem was encountered with a SwitchProducer having the EDAlias
case, but I think the problem could happen also without
SwitchProducer.
…sConditionalTask_125x

[12_5_X] Use "best matching" EDAlias in module dependence checks when placing ConditionalTask modules in Path
[12.5.X] Update to sqrt(s) in the PV alignment validation plotting macros
[12.5.X] `MillePedeDQMModule`: add string MonitorElement to signal if the update was vetoed
Read SoA scalars and Eigen columns from a ROOT streamer [12.5.x]
[125X] Change LG and HG Tk PCL output tags
[12_5_X] [L1T] Backport of: phase-2, update trackjet simulation
(cherry picked from commit f51be45)
(cherry picked from commit f6ed3b4)
(cherry picked from commit a883240)
(cherry picked from commit 7701e6a)
(cherry picked from commit b07a309)
(cherry picked from commit e6d49f5)
(cherry picked from commit 8ec852a)
(cherry picked from commit 3e7a998)
(cherry picked from commit d1362be)
(cherry picked from commit 57a365d)
(cherry picked from commit 9e4475e)
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40628/33909

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@Martin-Grunewald
Copy link
Contributor

-1
claimed to be a backport but is submitted to master

@nhduongvn
Copy link
Contributor Author

-1 claimed to be a backport but is submitted to master
Hi @Martin-Grunewald, how can I make a pull request to submit to CMSSW_12_5_X?

@Martin-Grunewald
Copy link
Contributor

See here http://cms-sw.github.io/tutorial.html, scroll down:

Or change the “base branch”, i.e. the one to which you want to have your changes merged. Starting from CMSSW_9_1_X and later the base branch for the latest development release is the master branch.

@Martin-Grunewald
Copy link
Contributor

However, you need to make your changes within 12_5 as you can not submit a PR based on a later release to an earlier release without pulling in a larger number of unrelated commits.

@ChrisMisan
Copy link
Contributor

-alca

  • not a backport
  • invalid commit structure

@nhduongvn
Copy link
Contributor Author

This is a wrong backport so I cancel this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment