Phase2-hgx335P Take care of invalid HGCal scintillator DetIDs

[bsunanda]

PR description:

Take care of invalid HGCal scintillator DetIDs. The bug fix will affect both V16 and V17 geometries.

PR validation:

Use scripts in Validation/HGCalValidation/script

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40668/34014

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40668/34014/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40668/34014/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40668/34015

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a7d44/30352/summary.html
COMMIT: 3766654
CMSSW: CMSSW_13_0_X_2023-02-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40668/30352/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555470
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[bsunanda]

@srimanob @civanch Please approve this PR. After this I can address the cassette shift issue

[srimanob]

Hi @bsunanda

Do I understand correctly from PR description is that this is a bug-fix PR, its effect should be seen in samples, i.e. relvals, since no change is seen in PR test. So that I can mark this PR as a bug-fix. Thanks.

[bsunanda]

@srimanob @civanch This is indeed a bug fix. Some of the borderline hits in scintillators were marked as invalid. This would have created a small change after Digi step.

[srimanob]

type bug-fix

[srimanob]

+Upgrade

This PR is a bugfix to handle for HGCal DetID. PR test does not show the difference. This should be followed up when relvals are available, together with effects from previous and coming PRs. FYI @cms-sw/pdmv-l2

[bsunanda]

+geometry

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1