Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update serialisation generator script #4068

Merged
merged 1 commit into from Jun 2, 2014

Conversation

apfeiffer1
Copy link
Contributor

  • change the warning about apparently empty classed to "info" as there are legitimate cases where a class does not have data members but needs to be serialised (e.g. if inheriting from another serialised class).
  • ignore architecture specific flags (-mtune... and -march...) when processing - this specific part should (once back ported to 71x) replace PR condformats_serialization_generate.py: ignore -march and -mtune compiler flags #4067 by A. Bocci.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

update serialisation generator script

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@apfeiffer1
Copy link
Contributor Author

+1

On Sat, May 31, 2014 at 4:17 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

update serialisation generator script

It involves the following packages:

CondFormats/Serialization

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @Degano
https://github.com/degano, @nclopezo https://github.com/nclopezo can
you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.


Reply to this email directly or view it on GitHub
#4068 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 2, 2014
Update serialisation generator script.
@ktf ktf merged commit 5baac68 into cms-sw:CMSSW_7_2_X Jun 2, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants