Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS DQM error plots #40688

Merged
merged 2 commits into from Feb 7, 2023
Merged

PPS DQM error plots #40688

merged 2 commits into from Feb 7, 2023

Conversation

fabferro
Copy link
Contributor

@fabferro fabferro commented Feb 3, 2023

PR description:

This PR introduces new plots for monitoring the errors in PPS Pixel data taking and unpacking.
The plots are created per FED and per DetId to ease the error understanding and debugging.

PR validation:

Use of Run2 data via 136 WFs

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40688/34044

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

  • DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Feb 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2023

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878101/30407/summary.html
COMMIT: 71caacd
CMSSW: CMSSW_13_0_X_2023-02-05-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40688/30407/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 05-Feb-2023 21:00:48 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CTPPSPixelDQMSource label='ctppsPixelDQMOfflineSource'
Exception Message:
MissingParameter: The required parameter 'tagTrigResults' was not specified.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Feb-2023 21:04:56 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CTPPSPixelDQMSource label='ctppsPixelDQMOfflineSource'
Exception Message:
MissingParameter: The required parameter 'tagTrigResults' was not specified.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Feb-2023 21:07:50 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CTPPSPixelDQMSource label='ctppsPixelDQMOfflineSource'
Exception Message:
MissingParameter: The required parameter 'tagTrigResults' was not specified.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
  • 140.56140.56_RunHI2018/step2_RunHI2018.log
  • 140.6140.6_RunHI2022/step2_RunHI2022.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40688/34075

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

Pull request #40688 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878101/30439/summary.html
COMMIT: 331e598
CMSSW: CMSSW_13_0_X_2023-02-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40688/30439/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555464
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8746.788999999999 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 514.517 KiB CTPPS/TrackingPixel
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@emanueleusai
Copy link
Member

If you need this code for the upcoming data taking period, could you please provide a backport to 12_6?

@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2023

+1

@cmsbuild cmsbuild merged commit 356b42c into cms-sw:master Feb 7, 2023
@fabferro
Copy link
Contributor Author

fabferro commented Feb 7, 2023

If you need this code for the upcoming data taking period, could you please provide a backport to 12_6?

@emanueleusai Ok. Does this mean that I also have to backport PR #40660 that fixes a bug in error identification at the Event filter level?

@emanueleusai
Copy link
Member

apologies, my language wasn't precise enough. The backport is needed is you need this PR for the upcoming MWGR. If you need it only for actual collision data, assuming we will use 13_X for that, then a backport to 12_6 is not needed.

@fabferro
Copy link
Contributor Author

fabferro commented Feb 8, 2023

apologies, my language wasn't precise enough. The backport is needed is you need this PR for the upcoming MWGR. If you need it only for actual collision data, assuming we will use 13_X for that, then a backport to 12_6 is not needed.

Ah, ok. Then I'll do no backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants