[DQM][CLANG] Fix warnings reported by clang 14 #40721
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40721/34119
|
|
A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master. It involves the following packages:
@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-865232/30499/summary.html Comparison SummarySummary:
|
|
+1
|
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Hello @emanueleusai, categories are taken from https://github.com/cms-sw/cms-bot/blob/master/categories_map.py. I can update it if the module is not correctly labeled. Thanks! |
In principle it should fall into the "analysis" category, but perhaps @cms-sw/hcal-dpg-l2 knows why it was put under "dqm" |
This tool is a remote monitoring tool(RMT), so I can understand why it was initially put under "dqm". |
|
Well, it's an interdisciplinary stuff (category boundaries are often not really stone-carved)... When a request for the new package has been discussed back then (2019), |
|
and moreover, Salavat, in fact, this RMT package is launched independently of the DQM. So, my last action was just commented 3 lines in the DPGAnalysis/HcalTools/plugins/CMTRawAnalyzer.cc . In principle, I can Close PR and renew it in next week if it help ?
Let me know, should I do that.
…________________________________
From: Salavat Abdullin ***@***.***
Sent: 10 February 2023 15:17
To: cms-sw/cmssw
Cc: Alexandr Zhokin; Mention
Subject: Re: [cms-sw/cmssw] [DQM][CLANG] Fix warnings reported by clang 14 (PR #40721)
Well, it's an interdisciplinary stuff (category boundaries are often not really stone-carved)...
This multi-function package is used:
(i) as an auxiliary (wrt regular DQM) tool for HCAL monitoring by experts
(ii) for data certification
(iii) as a "helper" in phi-calibration analysis etc.
When a request for the new package has been discussed back then, the emphasis was on (i)(ii), if I remember it right...
But it wasn't considered to be a part of the "regular DQM".
—
Reply to this email directly, view it on GitHub<#40721 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHOUBA2223KLYZAH5LH5PTWWZEYPANCNFSM6AAAAAAUVBFQMM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@zhokin2 In this case I suppose the least-efforts option would be to close your #40732 and to submit a new one after (on top of) this PR, when it will appear in coming IB(s). |
|
OK, probably yeas. So, I close the PR.
…________________________________
From: Salavat Abdullin ***@***.***
Sent: 10 February 2023 15:56
To: cms-sw/cmssw
Cc: Alexandr Zhokin; Mention
Subject: Re: [cms-sw/cmssw] [DQM][CLANG] Fix warnings reported by clang 14 (PR #40721)
@zhokin2<https://github.com/zhokin2>
Do you mean you recently submitted fix #40732<#40732>
is in conflict with this one
#40732 (comment)<#40732 (comment)>
In this case I suppose the least-efforts option would be to close your #40732<#40732> and to submit a new one after (on top of) this PR, when it will appear in coming IB(s).
—
Reply to this email directly, view it on GitHub<#40721 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHOUBDTJUTAE3N6P4CRZZ3WWZJJ5ANCNFSM6AAAAAAUVBFQMM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This PR fixes clang 14 warnings about variables set but unused in module
DPGAnalysis/HcalTools.