Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TkAl] Further fixes to JetHT Validation #40722

Merged
merged 4 commits into from Feb 8, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 8, 2023

PR description:

This PR fixes another couple of bugs reported by @jusaviin in the context of running the JetHT validation (see report at the Tracker Alignment meeting of 7th of Feb 2023).
These were mostly related to plotting:

PR validation:

Relies on the existing (and augmented) unit tests: scram b runtests_JetHTall.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Feb 8, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Feb 8, 2023

urgent

  • @cms-sw/alca-l2 please consider this straightforward set of fixes for inclusion in 13.0.0.

@cmsbuild cmsbuild added the urgent label Feb 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40722/34122

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 8, 2023

@cmsbuild, please test

@tvami
Copy link
Contributor

tvami commented Feb 8, 2023

+alca

  • unit tests testing the changes have already passed

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b976/30501/summary.html
COMMIT: 33b6fc0
CMSSW: CMSSW_13_0_X_2023-02-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40722/30501/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555852
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555824
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants