-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCAL Fb DQM monitoring at layer1 #40751
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40751/34165
|
A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for master. It involves the following packages:
@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type hcal |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a882c/30601/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR includes additional calolayer1 DQM monitoring elements for HCAL LLP trigger feature bits. Added elements are the 6 fine grain bits occupancy readout at uHTR/layer1 and their comparison, and the single LLP feature bit output expected vs emulated.
PR validation:
Validated by running offline DQM on past commissioning runs, expected plots are produced. It has also been included in the online DQM production release based on 12_6_3 (#40737) and tested online during MWGR on 9 Feb. Test went fine, so this PR to master is to make it permanent.