Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL Fb DQM monitoring at layer1 - online DQM test 12_6_3 #40737

Merged
merged 2 commits into from Feb 15, 2023

Conversation

hftsoi
Copy link
Contributor

@hftsoi hftsoi commented Feb 9, 2023

PR description:

This PR includes additional calolayer1 DQM monitoring elements for HCAL LLP trigger feature bits. Added elements are the 6 fine grain bits occupancy readout at uHTR/layer1 and their comparison, and the single LLP feature bit output expected vs emulated. This is intended to be used for short test in online DQM production for MWGR, therefore PR is closed immediately after opened.

PR validation:

Validated by running offline DQM on past commissioning runs, expected plots are produced.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for CMSSW_12_6_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf7972/30558/summary.html
COMMIT: 768ecfd
CMSSW: CMSSW_12_6_X_2023-02-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40737/30558/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460237
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460210
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7386.2999999999965 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 369.315 KiB L1T/L1TStage2CaloLayer1
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

syuvivida commented Feb 10, 2023

+1
Last night we tested this PR at P5 with 12_6_3 and the streamers of run 363397 and @hftsoi confirmed the output root files contain the correct information (with added histograms).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@hftsoi hftsoi reopened this Feb 11, 2023
@cmsbuild
Copy link
Contributor

Pull request #40737 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

@hftsoi
Copy link
Contributor Author

hftsoi commented Feb 11, 2023

Reopen this PR as the online DQM test went fine during MWGR on 9 Feb, and a new PR to master (#40751) has been opened to make it permanent.

@emanueleusai
Copy link
Member

type hcal

@emanueleusai
Copy link
Member

backport of #40751

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf7972/30602/summary.html
COMMIT: bc788d2
CMSSW: CMSSW_12_6_X_2023-02-12-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40737/30602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460357
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460333
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7386.2999999999965 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 369.315 KiB L1T/L1TStage2CaloLayer1
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@emanueleusai
Copy link
Member

Differences in L1T CaloLayer DQM plot as expected

@perrotta
Copy link
Contributor

perrotta commented Feb 14, 2023

@hftsoi please prepare a backport also for 13_0_X, if you want to use it also during this year data taking, and not only during MWGRs

@hftsoi
Copy link
Contributor Author

hftsoi commented Feb 14, 2023

Thanks @perrotta for reminding, backport to 13_0_X is opened at #40768

@perrotta
Copy link
Contributor

+1

  • Master PR succesfully integrated in CMSSW_13_1_X_2023-02-14-2300

@cmsbuild cmsbuild merged commit a9d41ba into cms-sw:CMSSW_12_6_X Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants