Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_6_X] Switch file catalog back to Rucio catalog #40755

Merged

Conversation

makortel
Copy link
Contributor

PR description:

Following Tier0 being now able to use both Trivial File Catalog and Rucio Catalog (dmwm/WMCore#11481 (comment)), this PR changes the file catalog back to Rucio catalog by reverting #40685.

PR validation:

None

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_12_6_X.

It involves the following packages:

  • FWCore/Catalog (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

hold

Waiting for the outcome of tests mentioned in dmwm/WMCore#11481 (comment)

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cb2ab/30609/summary.html
COMMIT: fabdff0
CMSSW: CMSSW_12_6_X_2023-02-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40755/30609/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460477
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460452
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@germanfgv
Copy link
Contributor

@makortel My test was successful. We are now able to use RucioCatalog.

@makortel
Copy link
Contributor Author

Thanks @germanfgv !

@makortel
Copy link
Contributor Author

unhold

@makortel
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 15, 2023

@germanfgv @makortel thank you for your checks
@makortel , just to be sure: your "+core" supersedes what you told yesterday at the ORP, that you would have waited for making the switch after next week MWGR, to stay on the safe side. We want to start building the 12_6_X release for it, and given the results of the checks I'd include this PR in that release: can you confirm?

@makortel
Copy link
Contributor Author

@perrotta (apologies for being confusing yesterday) I confirm including this PR for the release to be used in MWGR next week should be safe now (in light of the tests done at Tier0).

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d327c97 into cms-sw:CMSSW_12_6_X Feb 15, 2023
@makortel makortel deleted the revert-40685-revertCatalogToTFC_126x branch February 15, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants