Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Only compare geometry in Geometry/TrackerGoeometryBuilder test #40759

Conversation

perrotta
Copy link
Contributor

Removed inclusion of SimpleMemoryCheck and Timing service in the test to avoid those causing non-geometry related failures.

The test was previously failing because of a change to the output of SimpleMemoryCheck.

Backport of #40757

Removed inclusion of SimpleMemoryCheck and Timing service in
the test to avoid those causing non-geometry related failures.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_13_0_X.

It involves the following packages:

  • Geometry/TrackerGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@VourMa, @JanFSchulte, @VinInn, @bsunanda, @mmusich, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33cf29/30615/summary.html
COMMIT: fd10663
CMSSW: CMSSW_13_0_X_2023-02-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40759/30615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555972
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555947
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

+1

  • Unit test in master IBs got fixed

@cmsbuild cmsbuild merged commit 846a832 into cms-sw:CMSSW_13_0_X Feb 14, 2023
@perrotta perrotta deleted the fixUnitTestGeometry_TrackerGeometryBuilder branch February 14, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants