Changed internals of Digest to use std::array

[Dr15Jones]

PR description:

Changed from using a C style array to an std::array.

One of our code quality checkers was complaining about the use of sizeof to determine number of entries in the container. std::array is just cleaner.

PR validation:

Code compiles and framework unit tests pass.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40778/34208

• This PR adds an extra 24KB to repository

[Dr15Jones]

please test

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• DataFormats/Provenance (core)
• FWCore/Utilities (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit, @rovere, @felicepantaleo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ba1ab/30652/summary.html
COMMIT: af965c9
CMSSW: CMSSW_13_1_X_2023-02-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40778/30652/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich [TkAl all-in-one tool] Improve documentation and unit test coverage #40746
• @fwyzard Alpaka-related updates #40771

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ba1ab/30652/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ba1ab/30652/git-merge-result

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556272
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556247
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[fwyzard]

Suggested change

	copy_all(temp1, temp.bytes.begin());
	copy_all(temp1, temp.bytes.data());

?
begin() supposedly returns an iterator, is it guaranteed to be a pointer ?

[fwyzard]

actually no, I guess copy_all does take an iterator...

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1