Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @standardDQM for Run-3 re-HLT workflows #40804

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 17, 2023

PR description:

Title says it all, in reply to #40261 (comment).

PR validation:

Run successfully runTheMatrix.py -l 140.043 -t 4 -j 8 and runTheMatrix.py -l 139.004 -t 4 -j 8.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. I think it might be useful to backport to 13.0.x.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 17, 2023

test parameters:

  • workflows = 139.004, 140.003, 140.023, 140.043, 140.063

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40804/34235

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40804/34238

@cmsbuild
Copy link
Contributor

Pull request #40804 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 17, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32b16d/30707/summary.html
COMMIT: 734fd54
CMSSW: CMSSW_13_1_X_2023-02-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40804/30707/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1707 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 3812746
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3812708
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 562180.4299999999 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 139.004,... ): 39899.932 KiB HLT/JME
  • DQMHistoSizes: changed ( 139.004,... ): 12323.616 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 139.004,... ): 12284.354 KiB HLT/EXO
  • DQMHistoSizes: changed ( 139.004,... ): 11211.193 KiB HLT/BTV
  • DQMHistoSizes: changed ( 139.004,... ): 10388.740 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 139.004,... ): 5333.370 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 139.004,... ): 4813.427 KiB HLT/TOP
  • DQMHistoSizes: changed ( 139.004,... ): 4466.368 KiB HLT/HIG
  • DQMHistoSizes: changed ( 139.004,... ): 3494.898 KiB HLT/EGM
  • DQMHistoSizes: changed ( 139.004,... ): 3211.306 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 139.004 ): ...
  • Checked 233 log files, 179 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 17, 2023

DQMHistoSizes: changed ( 139.004,... ): 39899.932 KiB HLT/JME
DQMHistoSizes: changed ( 139.004,... ): 12323.616 KiB HLT/Tracking
DQMHistoSizes: changed ( 139.004,... ): 12284.354 KiB HLT/EXO
DQMHistoSizes: changed ( 139.004,... ): 11211.193 KiB HLT/BTV
DQMHistoSizes: changed ( 139.004,... ): 10388.740 KiB HLT/SiStrip
DQMHistoSizes: changed ( 139.004,... ): 5333.370 KiB HLT/Pixel
DQMHistoSizes: changed ( 139.004,... ): 4813.427 KiB HLT/TOP
DQMHistoSizes: changed ( 139.004,... ): 4466.368 KiB HLT/HIG
DQMHistoSizes: changed ( 139.004,... ): 3494.898 KiB HLT/EGM
DQMHistoSizes: changed ( 139.004,... ): 3211.306 KiB HLT/SUSY

as expected now there is HLT monitoring

@srimanob
Copy link
Contributor

+Upgrade

Clarifying on what DQM should be used Run3-reHLT.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2023

@cms-sw/pdmv-l2 any objections to these changes?

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d2f9738 into cms-sw:master Feb 21, 2023
@mmusich mmusich deleted the use_standardDQM_for_re-HLT_workflows branch February 21, 2023 08:54
@missirol
Copy link
Contributor

I think it might be useful to backport to 13.0.x.

Since I agree with this, I opened the 13_0_X backport in #40872.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2023

Since I agree with this, I opened the 13_0_X backport in #40872.

thanks. Sorry, I planned to do it, but then forgot about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants