Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to Alpaka tests [13.0.x] #40809

Merged
merged 4 commits into from Feb 19, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 17, 2023

PR description:

This PR makes some minor improvements to the Alpaka stand-alone and framework-based tests, that came up during the Alpaka tutorials on the 16-17 February:

  • remove one leftover import from writer.py
  • simplify getting the Device type from the Queue in AlpakaESTestData.h
  • migrate the test modules from stream to global
  • allocate host buffers in pinned memory accessible by the Platform devices in testKernel.dev.cc

PR validation:

All unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40808 to 13.0.x for consistency.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 17, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

backport #40808

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

Note: currently this PR includes #40796, so it would be better to merge that one first.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f84a/30714/summary.html
COMMIT: 150d6d1
CMSSW: CMSSW_13_0_X_2023-02-17-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40809/30714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 21 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556247
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19812
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 1 / 3 workflows

@fwyzard fwyzard changed the base branch from CMSSW_13_0_X to CMSSW_13_1_X February 17, 2023 17:51
@fwyzard fwyzard changed the base branch from CMSSW_13_1_X to CMSSW_13_0_X February 17, 2023 17:51
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 17, 2023

I changed the base branch and back again to force GitHub to re-evaluate the list of commits included in the PR.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b9e392b into cms-sw:CMSSW_13_0_X Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants