[13_0_X] Fix RPC and GEM TP unpacking in EMTF unpacker

[eyigitba]

PR description:

This is a backport of #40797

As reported by RPC experts, EMTF unpacker is currently producing invalid RPC and GEM hits. This is a result of #39388 where EMTF switched to packing 2 RPC/GEM TPs per dataword. I forgot to add a valid flag which wasn't needed before. However, in the current scenario if there is only one RPC/GEM TP in the dataword, the second TP is filled with garbage and results in invalid TPs in DQM plots.

These invalid TPs are later dropped by the EMTF emulator, so the only affected part is DQM plots. This PR adds the valid flag check to these unpackers. It is expected to see DQM mismatches in 2022 data after this PR.

PR validation:

Validated by running on 2022 data to verify that the invalid TPs are now gone from DQM plots after the changes. Since the TPs should always be valid anyway, there is no other expected impact.

Before:

After:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #40797

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_13_0_X.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix RPC and GEM TP unpacking in EMTF unpacker #40797

[epalencia]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4d011/30777/summary.html
COMMIT: 83470f2
CMSSW: CMSSW_13_0_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40836/30777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 24 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529029
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529007
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #40797

[perrotta]

+1