Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS diamond mapping XML for 2023 run (backport) #40843

Merged
merged 5 commits into from Feb 22, 2023

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Feb 21, 2023

PR description:

This PR updates the XML mappings for PPS diamond detectors for 2023 run campaign.
The change is due to hardware changes needed to be implemented in PPS to cope with higher trigger rate.
Unfortunately we come up late with this PS, as detectors will be installed end of February 2023.
Backward compatibility is sustained.
Backport of #40763

PR validation:

This PR was validated with relvals 136.793, 1043 and 1044 (which run PPS reconstruction), as in #40763

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #40763 into 13_0_X, as requested in #40763 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2023

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_13_0_X.

It involves the following packages:

  • CondFormats/PPSObjects (alca)
  • EventFilter/CTPPSRawToDigi (reconstruction)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @tocheng, @Martin-Grunewald, @missirol, @mmusich, @forthommel, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

type ctpps

@mandrenguyen
Copy link
Contributor

backport of #40763

@mandrenguyen
Copy link
Contributor

test parameters:

workflows = 136.793,1043,1044

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fa90c/30794/summary.html
COMMIT: 6dffcb5
CMSSW: CMSSW_13_0_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40843/30794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 18 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3529631
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529603
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 221 log files, 166 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 22, 2023

+alca

  • as agreed in the master PR, this really needs to go to the EventSetup -- will be done in a followup PR

@mandrenguyen
Copy link
Contributor

+reconstruction
Needed for data taking

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants