Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise local variables to null pointers [13.0.x] #40894

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 28, 2023

PR description:

Initialise C strings to null pointers. Otherwise, when CUDA is not available, the CUDA stub library functions will not (re)set them, leaving them uninitialised.

PR validation:

Fixes testCudaCheck on ARM.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40840 to CMSSW 13.0.x.

Initialise C strings to null pointers. Otherwise, when CUDA is not available,
the CUDA stub library functions will not (re)set them, leaving them uninitialised.
@fwyzard fwyzard changed the title Initialise local variables to null pointers Initialise local variables to null pointers [13.0.x] Feb 28, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Feb 28, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_0_X.

It involves the following packages:

  • HeterogeneousCore/CUDAUtilities (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 28, 2023

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 28, 2023

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 28, 2023

backport #40840

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 28, 2023

please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 28, 2023

not urgent, but please merge for 13.0.0 to avoid unit test failures

@perrotta
Copy link
Contributor

+1

  • Not needed to wait for the result of the tests in the master IB: this can't hurt

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03841f/30952/summary.html
COMMIT: 3e245d9
CMSSW: CMSSW_13_0_X_2023-02-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40894/30952/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557190
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Mar 1, 2023

@perrotta, looks like this didn't get merged.

@perrotta
Copy link
Contributor

perrotta commented Mar 1, 2023

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants