Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused dependencies from BuildFiles #40906

Merged
merged 1 commit into from Mar 4, 2023
Merged

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #40181).

In some cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.

This PR cleans unnecessary includes from CMSSW BuildFiles that were added in the last months.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40906/34390

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2023

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • CUDADataFormats/TrackingRecHit (heterogeneous, reconstruction)
  • CalibTracker/SiStripCommon (alca)
  • DPGAnalysis/SiStripTools (analysis)
  • DQM/SiStripMonitorApproximateCluster (dqm)
  • Geometry/HGCalTBCommonData (geometry)
  • HeterogeneousTest/CUDAOpaque (heterogeneous)
  • HeterogeneousTest/ROCmOpaque (heterogeneous)
  • IOMC/RandomEngine (core)
  • JetMETCorrections/Modules (reconstruction)
  • JetMETCorrections/Objects (reconstruction)
  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
  • L1Trigger/Phase2L1Taus (l1)
  • RecoJets/JetAnalyzers (reconstruction)
  • SimG4CMS/ShowerLibraryProducer (simulation)

@bsunanda, @ChrisMisan, @cecilecaillol, @civanch, @yuanchao, @makortel, @cmsbuild, @fwyzard, @mandrenguyen, @pmandrik, @smuzaffar, @Dr15Jones, @epalencia, @emanueleusai, @mdhildreth, @AdrianoDee, @syuvivida, @micsucmed, @francescobrivio, @malbouis, @clacaputo, @srimanob, @saumyaphor4252, @aloeliger, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @VourMa, @jandrea, @robervalwalsh, @Martin-Grunewald, @bsunanda, @fioriNTU, @threus, @seemasharmafnal, @venturia, @mmarionncern, @hdelanno, @missirol, @makortel, @JanFSchulte, @jdolen, @slomeo, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @idebruyn, @mmusich, @mtosi, @fabiocos, @clelange, @gbenelli, @wddgit, @ahinzmann, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Mar 1, 2023

+heterogeneous

@aloeliger
Copy link
Contributor

+l1

@makortel
Copy link
Contributor

makortel commented Mar 1, 2023

+core

@tvami
Copy link
Contributor

tvami commented Mar 1, 2023

---> test DRNTest had ERRORS

is this a known problem?

@makortel
Copy link
Contributor

makortel commented Mar 1, 2023

The DRNTest has been failing randomly in the past. Taking a closer look now, the symptoms seem to match #32918

@tvami
Copy link
Contributor

tvami commented Mar 1, 2023

+alca

@srimanob
Copy link
Contributor

srimanob commented Mar 2, 2023

+Upgrade

Technical PR.

@civanch
Copy link
Contributor

civanch commented Mar 2, 2023

+1

@clacaputo
Copy link
Contributor

+reconstruction

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2023

merge

@cmsbuild cmsbuild merged commit 89d0edd into cms-sw:master Mar 4, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment