Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed TrackWithVertexRefSelector to a stream module. #4091

Conversation

Dr15Jones
Copy link
Contributor

Static analysis and helgrind showed it is safe to convert this
module to a stream module. Thread performance analysis showed
this conversion is needed for efficient threading.
To do the conversion, I introduced ObjectSelectorStream templated
base class.

Static analysis and helgrind showed it is safe to convert this
module to a stream module. Thread performance analysis showed
this conversion is needed for efficient threading.
To do the conversion, I introduced ObjectSelectorStream templated
base class.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Changed TrackWithVertexRefSelector to a stream module.

It involves the following packages:

CommonTools/RecoAlgos
CommonTools/UtilAlgos

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

Same as #4085 for CMSSW_7_2

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

@StoyanStoynev
Copy link
Contributor

+1
Some difference in Jenkins (1 DQM plot in wf 4.53) prompted further checks.
Tested 6d59975 in CMSSW_7_2_X_2014-06-05-0200.
1000 events with wf 4.53 showed difference in phi-angle plots (a group of SuperClusterActivityFilter and PixelMatchFilter histograms) like these
4 53more_compar1
4 53more_compar2.
Further checks with 1-2k events with photon/electron guns and ttbar/QCD wf showed a couple of cases with a small difference in SuperClusterActivityFilter (same phi-angle feature at phi~0). Likely a numerical instability. No other differences.

@Dr15Jones
Copy link
Contributor Author

@vadler, @Degano ping?

1 similar comment
@Dr15Jones
Copy link
Contributor Author

@vadler, @Degano ping?

@monttj
Copy link
Contributor

monttj commented Jun 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 15, 2014
…rStreamModule_72

Changed TrackWithVertexRefSelector to a stream module.
@ktf ktf merged commit b441f87 into cms-sw:CMSSW_7_2_X Jun 15, 2014
@Dr15Jones Dr15Jones deleted the makeTrackWithVertexRefSelectorStreamModule_72 branch June 25, 2014 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants