Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutexes for thread safe use of TBaseClass #4092

Merged
merged 2 commits into from Jun 26, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 2, 2014

In ROOT 5, the use of TBaseClass is not thread safe. This pull request, issued at the request of Chris Jones,
adds mutexes for CINT around the uses of TBaseClass, except for those in Fireworks, since Fireworks need not be thread safe.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

A new Pull Request was created by @wmtan for CMSSW_7_1_X.

Add mutexes for thread safe use of TBaseClass

It involves the following packages:

CommonTools/Utils
FWCore/Utilities

@nclopezo, @monttj, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1
Bug fix to avoid deadlocks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

Pull request #4092 was updated. @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

Comparison with the baseline Still running...

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2014

+1

for #4092 eb9911e

jenkins tests completed, should be a good enough indication nothing is wrong

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2014

@slava77
Copy link
Contributor

slava77 commented Jun 10, 2014

do we give up on this or is it needed for 71X still?

@Dr15Jones
Copy link
Contributor

this is still needed

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2014

@vadler @monttj
please sign this if you don't have any concerns

@ktf ktf modified the milestones: Next CMSSW_7_1_X, CMSSW_7_1_0 Jun 23, 2014
@monttj
Copy link
Contributor

monttj commented Jun 25, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 26, 2014
Add mutexes for thread safe use of TBaseClass
@davidlange6 davidlange6 merged commit f9dadf0 into cms-sw:CMSSW_7_1_X Jun 26, 2014
@ktf ktf mentioned this pull request Jun 26, 2014
@wmtan wmtan deleted the ThreadSafeUseOfTBaseClass branch June 26, 2014 15:03
ktf added a commit to ktf/cmssw that referenced this pull request Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants