Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent heap-buffer-overflow in SiPixelDynamicInefficiencyPUParametrization #40944

Merged
merged 1 commit into from Mar 3, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 3, 2023

resolves #40930

PR description:

Title says it all.

PR validation:

scram b runtests runs to completion in CMSSW_13_1_ASAN_X_2023-03-01-2300.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Mar 3, 2023

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40944/34430

  • This PR adds an extra 20KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Mar 3, 2023

@cmsbuild, please test for CMSSW_13_1_ASAN_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/SiPixelPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@VinInn, @mroguljic, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 3, 2023

@cmsbuild, please abort

  • failure in addOnTests cannot be related. On the other hand the unit tests already passed

Screenshot from 2023-03-03 10-54-56

@mmusich
Copy link
Contributor Author

mmusich commented Mar 3, 2023

@cmsbuild, please test

@tvami
Copy link
Contributor

tvami commented Mar 3, 2023

+db

  • unit test passed, addOn test in ASAN has nothing to do with this PR, addOn for vanilla release passed

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46830e/31033/summary.html
COMMIT: f54c77a
CMSSW: CMSSW_13_1_X_2023-03-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40944/31033/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529668
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

merge

@cmsbuild cmsbuild merged commit adc97a6 into cms-sw:master Mar 3, 2023
@mmusich mmusich deleted the preventHeapOverBufferOverflow branch March 7, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASAN_X] Heap buffer overflow in testPixelPayloadInspector unit test
4 participants