Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ: New input source (13_1_X) #40960

Merged
merged 1 commit into from Mar 15, 2023
Merged

Conversation

smorovic
Copy link
Contributor

@smorovic smorovic commented Mar 6, 2023

PR description:

New modular DAQ input source for phase2 and L1 scouting. Also implements supports for the current DAQ3 data model (potentially as replacement for FedRawDataInputSource)

  • modified shared input file abstractions to support some modes of the new source and support 64-bit file and buffer size (> 4 GB).
  • new DAQProvenanceHelper constructor to support putting specific products into event.
  • FRD format updated to be used as orbit container for scouting data, with updated unit test
  • discovery of multiple input file locations in DaqDirector (for use in some modes)
  • currently includes run2 scouting support as a test, which will be replaced by run 3 scouting model (in development)

PR validation:

Added several test scripts. Currently they are not part of automated testing since new input source development is still not finished. Also tested in DAQ test cluster (openstack VMs)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40960/34456

  • This PR adds an extra 112KB to repository

  • Found files with invalid states:

    • EventFilter/Utilities/src/DAQSourceModels.cc:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40960/34458

  • This PR adds an extra 200KB to repository

  • Found files with invalid states:

    • EventFilter/Utilities/src/DAQSourceModels.cc:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

  • EventFilter/Utilities (daq)
  • FWCore/Sources (core)
  • IOPool/Streamer (core)

@smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @wddgit, @makortel this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

smorovic commented Mar 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89854c/31089/summary.html
COMMIT: 45dabea
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40960/31089/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89854c/31089/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89854c/31089/git-merge-result

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40960/34460

  • This PR adds an extra 200KB to repository

  • Found files with invalid states:

    • EventFilter/Utilities/src/DAQSourceModels.cc:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

Pull request #40960 was updated. @smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @smorovic can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40960/34655

  • This PR adds an extra 44KB to repository

@smorovic
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

Pull request #40960 was updated. @makortel, @smuzaffar, @Dr15Jones, @emeschi, @smorovic can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89854c/31292/summary.html
COMMIT: 643d2bc
CMSSW: CMSSW_13_1_X_2023-03-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40960/31292/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 20 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550724
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor Author

+daq

@makortel
Copy link
Contributor

Another incarnation of #39803

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d3459e1 into cms-sw:master Mar 15, 2023
11 checks passed
@smorovic smorovic deleted the 131X_new_source_v6 branch August 24, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants