Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-alca240 Add one more isolated bunch AlCaReco to the AlCa matrix #40970

Merged
merged 1 commit into from Mar 13, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 7, 2023

PR description:

Add one more isolated bunch AlCaReco to the AlCa matrix. May need to be back ported to CMSSW version 13_0_X

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

May need to be back ported to version 13_0_X

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 7, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40970/34470

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ef74e/31110/summary.html
COMMIT: 4c3fd37
CMSSW: CMSSW_13_1_X_2023-03-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40970/31110/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529727
  • DQMHistoTests: Total failures: 122
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3529582
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.016 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 7, 2023

This should have been tested together with your other PR -- or well in the first place the commit should have gone to the other PR. The wf 1002.3 and 1002.4 tests the AlCaRECO matrix through the ALCAPRODUCER:@allForPrompt mechanism.

Since you have testing rights and seem to be exercising them happily... I let you put a meaning cmsbuild command together that actually does something related to your changes

@tvami
Copy link
Contributor

tvami commented Mar 10, 2023

test parameters:

@tvami
Copy link
Contributor

tvami commented Mar 10, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ef74e/31198/summary.html
COMMIT: 4c3fd37
CMSSW: CMSSW_13_1_X_2023-03-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40970/31198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3647632
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3647607
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.032 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): 0.008 KiB MessageLogger/Warnings
  • Checked 220 log files, 166 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 10, 2023

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8702d42 into cms-sw:master Mar 13, 2023
12 checks passed
cmsbuild added a commit that referenced this pull request Mar 21, 2023
run3-alca240X Addition of one more Isolated bunch AlCaReco - backport of #40970 to version 13_0_X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants