-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Phase-1 Barrel Pixel Inner / Outer ladders numbering in several monitoring tools #40989
Fix Phase-1 Barrel Pixel Inner / Outer ladders numbering in several monitoring tools #40989
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40989/34500
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @rvenditti, @micsucmed, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
5f4ba3a
to
211299c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40989/34501
|
Pull request #40989 was updated. @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @rvenditti, @micsucmed, @francescobrivio can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f36c5/31139/summary.html Comparison SummarySummary:
|
+1
|
maybe we should ask an explicit signature from tracker? I feel like this is not very |
Chatted with Marco a bit and agreed that we dont need the trk-dpg signature, since now the PR touches the PI specifically, which is indeed purely |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
+alca
|
@tvami, |
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
please merge |
type bug-fix |
PR description:
In the (long) discussion begun at CMSTrackerDPG/Tasks#1 (comment) (and following), it became apparent that the convention used to define inner / outer Phase-1 Barrel Pixel ladders based on their offline numbering in several different places in
cmssw
has become wrong after the major geometry fix in PR #18651, after which the right convention is:to be compared with a ~recent (2018) pixel hadrography from the material budget analysis
PR validation:
cmssw
compiles.We DO expect regressions
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport PR, but it does need to be backported to at least 13_0_X for 2023 data-taking.
cc:
@sroychow @ferencek @mroguljic @tsusa @arossi83 @cardinia @antoniovagnerini