Fix Phase-1 Barrel Pixel Inner / Outer ladders numbering in several monitoring tools

[mmusich]

PR description:

In the (long) discussion begun at CMSTrackerDPG/Tasks#1 (comment) (and following), it became apparent that the convention used to define inner / outer Phase-1 Barrel Pixel ladders based on their offline numbering in several different places in cmssw has become wrong after the major geometry fix in PR #18651, after which the right convention is:

• evenly numbered ladder = inner ladder = flipped ladder (for BPix 1,2,3)
• oddly numbered ladder = inner ladder = flipped ladder (for BPix 4)

to be compared with a ~recent (2018) pixel hadrography from the material budget analysis

PR validation:

cmssw compiles.

We DO expect regressions

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport PR, but it does need to be backported to at least 13_0_X for 2023 data-taking.

cc:
@sroychow @ferencek @mroguljic @tsusa @arossi83 @cardinia @antoniovagnerini

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40989/34500

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)
• CondCore/AlignmentPlugins (db)
• CondCore/SiPixelPlugins (db)
• DQM/SiPixelPhase1Common (dqm)

@pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @rvenditti, @micsucmed, @francescobrivio can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @adewit, @sroychow, @tlampen, @tocheng, @VinInn, @mroguljic, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40989/34501

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #40989 was updated. @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @rvenditti, @micsucmed, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f36c5/31139/summary.html
COMMIT: 211299c
CMSSW: CMSSW_13_1_X_2023-03-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40989/31139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3530381
• DQMHistoTests: Total failures: 621
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529738
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• tests pass
• changes are expected in the Jenkins tests

[tvami]

maybe we should ask an explicit signature from tracker? I feel like this is not very alca specific as the PR would suggest right now

[cmsbuild]

New categories assigned: trk-dpg

@connorpa,@sroychow you have been requested to review this Pull request/Issue and eventually sign? Thanks

[tvami]

maybe we should ask an explicit signature from tracker? I feel like this is not very alca specific as the PR would suggest right now

Chatted with Marco a bit and agreed that we dont need the trk-dpg signature, since now the PR touches the PI specifically, which is indeed purely alca

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f36c5/31308/summary.html
COMMIT: 2473559
CMSSW: CMSSW_13_1_X_2023-03-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40989/31308/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 12 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550819
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550790
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass, input error is irrelevant

[mmusich]

@tvami, db signature is needed as well here.
Thanks.

[tvami]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

• Errors are due to read errors, unrelated to this PR.

[rappoccio]

please merge

[mmusich]

type bug-fix