Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ASAN Segmentation failure & heap-buffer-overflow in unit test Alignment/OfflineValidation/GCPall #41080

Merged
merged 1 commit into from Mar 18, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 17, 2023

resolves #41079

PR description:

Title says it all.

PR validation:

In CMSSW_13_1_X_2023-03-16-2300, scram b runtests_GCPall runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Mar 17, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41080/34694

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 17, 2023

@cmsbuild, please test for CMSSW_13_1_ASAN_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31361/summary.html
COMMIT: f3178b3
CMSSW: CMSSW_13_1_ASAN_X_2023-03-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41080/31361/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31361/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31361/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test NewStreamerZSTD had ERRORS
---> test NewStreamerUNCOMPRESSED had ERRORS
---> test NewStreamerLZMA had ERRORS
---> test NewStreamerZLIB had ERRORS
and more ...

@mmusich
Copy link
Contributor Author

mmusich commented Mar 17, 2023

OK, not enough

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41080/34700

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #41080 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 17, 2023

@cmsbuild, please test for CMSSW_13_1_ASAN_X

@mmusich
Copy link
Contributor Author

mmusich commented Mar 17, 2023

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/summary.html
COMMIT: 920dcdb
CMSSW: CMSSW_13_1_ASAN_X_2023-03-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41080/31371/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test NewStreamerUNCOMPRESSED had ERRORS
---> test NewStreamerLZMA had ERRORS
---> test NewStreamerZLIB had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
and more ...

@mmusich
Copy link
Contributor Author

mmusich commented Mar 17, 2023

@cmsbuild, please test

  • for the regular variant

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31382/summary.html
COMMIT: 920dcdb
CMSSW: CMSSW_13_1_X_2023-03-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41080/31382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550882
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550856
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 17, 2023

+alca

  • both ASAN and std CMSSW pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d92c05c into cms-sw:master Mar 18, 2023
16 of 17 checks passed
@mmusich mmusich deleted the fixGCPUnitTestASAN branch March 18, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASAN] Segmentation failure & heap-buffer-overflow in unit test Alignment/OfflineValidation/GCPall
4 participants