Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (4/N) #41017

Merged
merged 3 commits into from Mar 13, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Mar 9, 2023

backport of #41016

PR description:

Development of HLT menus for CMSSW_13_0_X.

This PR includes the integration of the JIRA tickets in [1], and has the following implications.

[1]

  • CMSHLT-2678: [HCAL] removed L1_SingleMuOpen seed from HLT_HcalPhiSym_v trigger
  • CMSHLT-2687: [BPH] update of Tau3Mu triggers (2023 L1T seeds)
  • CMSHLT-2688: [BPH] removed L1_DoubleMu3er2p0_SQ_OS_dR_Max1p4 seed from BPH dimuon triggers
  • CMSHLT-2689: [JME] use L1T-Jet-FWD2p5 seeds in PFJetFwd and DiPFJetAve triggers (2023 L1T seeds)
  • CMSHLT-2690: [BTV] update of BTagMu*DiJet triggers (2023 L1T seeds)
  • CMSHLT-2699: [HIG] added backup L1T VBFDiJetIsoTau seed (2023 L1T seed)

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41016

Development of HLT menus for 2023 data-taking and Run-3 MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @AdrianoDee, @bbilin, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @silviodonato, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Mar 9, 2023

test parameters:

@missirol
Copy link
Contributor Author

missirol commented Mar 9, 2023

The 'test parameters' above is tentative (and hopefully valid). If somebody has additional wfs in mind to test this PR, feel free to add them.

FYI: @cms-sw/alca-l2

@tvami
Copy link
Contributor

tvami commented Mar 9, 2023

looks reasonable to me! thanks @missirol

@tvami
Copy link
Contributor

tvami commented Mar 9, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4868b5/31173/summary.html
COMMIT: b7e1d59
CMSSW: CMSSW_13_0_X_2023-03-09-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41017/31173/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1367 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 130 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4766494
  • DQMHistoTests: Total failures: 1292
  • DQMHistoTests: Total nulls: 139
  • DQMHistoTests: Total successes: 4765041
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -173149.33 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -9818.210 KiB HLT/BTV
  • DQMHistoSizes: changed ( 12434.0,... ): -1531.818 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12434.0,... ): -1187.008 KiB HLT/TOP
  • DQMHistoSizes: changed ( 12434.0,... ): -1130.035 KiB HLT/HIG
  • DQMHistoSizes: changed ( 12434.0,... ): -1056.366 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): -344.597 KiB HLT/Objects
  • DQMHistoSizes: changed ( 12434.0,... ): -152.027 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12434.0,... ): -117.172 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): 57.377 KiB HLT/Filters
  • DQMHistoSizes: changed ( 12434.0,... ): -36.644 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 12434.0 ): ...
  • Checked 256 log files, 206 edm output root files, 59 DQM output files
  • TriggerResults: found differences in 12 / 57 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19852
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Mar 9, 2023

+hlt

  • The changes in the outputs of PR tests are in line with the updates to the HLT menus used in 20(22|23|24) MC RelVals and Run-3 data RelVals.

@srimanob
Copy link
Contributor

+Upgrade

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

No issues seen in CMSSW_13_1_X_2023-03-10-2300 in relation to the parent PR of this backport.

Reminder: this PR and #41007 need to be integrated in the same IB.

@missirol
Copy link
Contributor Author

No issues seen in CMSSW_13_1_X_2023-03-10-2300 in relation to the parent PR of this backport.

Reminder: this PR and #41007 need to be integrated in the same IB.

@cms-sw/orp-l2 , kind ping to review this backport PR (and #41007).

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a51a3a4 into cms-sw:CMSSW_13_0_X Mar 13, 2023
@missirol missirol deleted the HLTdevelopment130X branch March 13, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants