Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the bodies of FunctionDecl's too #4104

Merged
merged 1 commit into from Jun 11, 2014
Merged

check the bodies of FunctionDecl's too #4104

merged 1 commit into from Jun 11, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 3, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_2_X.

check the bodies of FunctionDecl's too

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

Pull request #4104 was updated. @Dr15Jones, @ktf can you please check and sign again.

@ktf
Copy link
Contributor

ktf commented Jun 6, 2014

@nclopezo, which commit did you check?

@nclopezo
Copy link
Contributor

nclopezo commented Jun 6, 2014

The tests started at 5:05 AM CET, so it they must have included f3f0eda

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

Pull request #4104 was updated. @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

Functions not tied to classes. Don't issues warnings from FunctionChecker
since this info is written to a file. Have clang geneerate plist files
when running ClassDumper,FunctionDumper and FunctionChecker.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

Pull request #4104 was updated. @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@gartung
Copy link
Member Author

gartung commented Jun 6, 2014

OK I decided to not change the scripts. The change is only to FunctionChecker.cpp so that it does not output warnings but still writes them to the file in $LOCALRT/tmp for use in generating the reports.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 11, 2014
Check the bodies of FunctionDecl's too.
@ktf ktf merged commit 1501a3a into cms-sw:CMSSW_7_2_X Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants