Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #4004 #4105

Merged
merged 1 commit into from Jun 3, 2014
Merged

Cleanup #4004 #4105

merged 1 commit into from Jun 3, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Jun 3, 2014

As discussed, this corrects the behavior of #4004 getting back the old behavior and still keeping clang happy.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Cleanup #4004

It involves the following packages:

MuonAnalysis/MomentumScaleCalibration

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@mmusich, @frmeier, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

ktf added a commit that referenced this pull request Jun 3, 2014
@ktf ktf merged commit 492b707 into cms-sw:CMSSW_7_1_X Jun 3, 2014
@ktf ktf deleted the cleanup-4004 branch June 3, 2014 19:49
@ktf
Copy link
Contributor Author

ktf commented Jun 3, 2014

Bypassing signatures since this is agreed to be the correct behavior.
@StoyanStoynev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants