Adapt latest PF settings in Phase2 Egamma HLT #41051
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41051/34623
|
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -59,7 +59,7 @@ | |||
| ), | |||
| clusterTimeResFromSeed = cms.bool(False), | |||
| excludeOtherSeeds = cms.bool(True), | |||
| maxIterations = cms.uint32(50), | |||
| maxIterations = cms.uint32(5), | |||
There was a problem hiding this comment.
As far as I understand, this changes the physics outputs of the Jet/MET HLT Phase-2 reco. Should I assume this change is okay with Jet/MET ?
There was a problem hiding this comment.
I think it would be good if they explicitly sign it off.
There was a problem hiding this comment.
@alpakpinar @theochatzis , I guess we wait for your feedback.
There was a problem hiding this comment.
Hello, we did some preliminary tests on performance and some thresholds for changing the iterations (you can see the results on the slides here ). From these we see no big effect from this change.
There was a problem hiding this comment.
Thanks a lot Theo! Please @Martin-Grunewald and @missirol consider that you have the green light from HLT Upgrade!
swagata87
force-pushed
the
AdaptParamsPhase2HLT
branch
from
7bd141c
to
3cce759
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41051/34642
|
|
Pull request #41051 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50d5e8/31346/summary.html Comparison SummarySummary:
|
|
+hlt Validated by POGs (see PR description, and #41051 (comment)). No changes seen in the outputs of PR tests, likely because HLT-DQM in Phase-2 wfs is largely missing, see #39362. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR is an attempt to align the parameters in
hltParticleFlowClusterHCALForEgammaandparticleFlowClusterHCALhltParticleFlowClusterHBHEForEgammaandparticleFlowClusterHBHEhltParticleFlowRecHitHBHEForEgammaandparticleFlowRecHitHBHEso that one of them can be deleted.
With this PR, Egamma will be using
PFRecHitHCALDenseIdNavigator(instead ofPFRecHitHCALNavigator),PFRecHitQTestHCALThresholdVsDepth(instead ofPFRecHitQTestThreshold),logWeightDenominatorByDetector(instead of onlylogWeightDenominator)(2) is expected to increase timing, so as a safeguard
maxIterationsis decreased from 50 to 5, similar to what was done for Run3 https://its.cern.ch/jira/browse/CMSHLT-2455Also, this PR addresses #40525 (comment)
Some changes in trigger results are expected.
PR validation:
For 1000 TTbar NoPU events, only change in result is this:
HLT_PFPuppiMETTypeOne140_PFPuppiMHT140NPassed25->24[With thanks to @hatakeyamak for useful feedback]