Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build genTauJets for undecayed taus and add tau decay-mode to genTauJets [13_0_X] #41104

Merged
merged 2 commits into from Mar 21, 2023

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Mar 20, 2023

PR description:

This PR enables creation of genTauJets for taus which were not decayed by the generator based on the tau's own data. In addition, information on decay-modes of generated taus is added to the genTauJets using the status flag. The decay-modes are codded following Tau POG standard (as defined in DataFormats/TauReco/interface/PFTau.h), while for undecayed (or others with abnormal decay-mode) taus the status is a negative number.

Backport of #41064 & #41092.

PR validation:

Validated during integration of original PRs #41064 & #41092, and revalidated with wf's 10024.0 & 148.0

Backport PR

It is backport of #41064 & #41092 to production releases of 13_0_X series for 2023.

Dr15Jones and others added 2 commits March 20, 2023 11:16
Instead of creating a dummy empty jet, taus which were not decayed
by the generator are now used to create a jet based on the tau's
own data. This avoids failures in the integration builds.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/JetMCAlgos (analysis)
  • PhysicsTools/JetMCUtils (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @AnnikaStein, @JyothsnaKomaragiri, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Mar 21, 2023

XX

@perrotta
Copy link
Contributor

please test
(let run the tests at least once in 13_0_X before merging...)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4fc27/31482/summary.html
COMMIT: 0fb664e
CMSSW: CMSSW_13_0_X_2023-03-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41104/31482/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ee96791 into cms-sw:CMSSW_13_0_X Mar 21, 2023
@mbluj mbluj deleted the CMSSW_13_0_X_GenTauJetStatus branch March 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants