Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (5/N) #41114

Merged
merged 1 commit into from Mar 22, 2023

Conversation

missirol
Copy link
Contributor

backport of #41113

PR description:

Development of HLT menus for CMSSW_13_0_X.

It includes the integration of the following JIRA tickets.

  • CMSHLT-2587: [HCAL,CSC,GEM] sync hcalRecAlgos and muonDetIdAssociator ES modules with Run-3 offline reco
  • CMSHLT-2635: [BPH] use pixel-triplet matching in low-mass di-electron triggers
  • CMSHLT-2637: [BPH] use pixel-triplet matching in HLT_SingleEle* control triggers
  • CMSHLT-2651: [DAQ] changed compression settings of all OutputModules to (algorithm = "ZSTD", level = 3)
  • CMSHLT-2684: [HIG] triggers for HH4b in semi-resolved topology
  • CMSHLT-2685: [HIG] added PNet-based VBF HToCC triggers
  • CMSHLT-2688: [BPH] added 2023 L1T seeds to BsMuMu triggers (part 2)
  • CMSHLT-2689: [JME] halved PSs of HLT_PFJetFwd80 and HLT_AK8PFJetFwd80 (part 2)
  • CMSHLT-2694: [B2G] added backups of AK8(Di,)PFJet*_MassSD(30,50) triggers
  • CMSHLT-2696: [TSG] store unseeded E/gamma in Scouting, and use separate L1EG-seeded Scouting triggers
  • CMSHLT-2698: [BPH] removal of four Dimuon0_Upsilon triggers from GRun (combined table unchanged)
  • CMSHLT-2701: [JME] additional HLT_Photon*EB_TightID_TightIso triggers
  • CMSHLT-2707: [EXO] moved MuShower-seeded DT/CSC-cluster triggers to Muon PD
  • CMSHLT-2721: [BPH] set PS=0 for HLT_Mu12_IP6_v and remove ParkingSingleMuon* streams/PDs from GRun
  • CMSHLT-2724: [EXO] added HLT-HT cut to L1_Mu6HT240-seeded displaced-jets triggers
  • CMSHLT-2726: [EGM] removed *ForBParking* Sequences from MC_Egamma_Open* triggers, and add MC_Egamma_Open* to GRun menu

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41113

Development of HLT menus for 2023 data-taking and Run-3 MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • workflows = 139.004,140.003,140.023,140.043,140.063,12634.0,12634.99,12834.0,13034.0,13034.99

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e34336/31469/summary.html
COMMIT: 8e9ac48
CMSSW: CMSSW_13_0_X_2023-03-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41114/31469/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.674.67_ZElSkim2012C/step2_ZElSkim2012C.log
  • 11634.9111634.91_TTbar_14TeV+2021_trackdnn/step2_TTbar_14TeV+2021_trackdnn.log
  • 11723.1711723.17_QCD_Pt_1800_2400_14+2021_seedingDeepCore/step2_QCD_Pt_1800_2400_14+2021_seedingDeepCore.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 97 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4775834
  • DQMHistoTests: Total failures: 2603
  • DQMHistoTests: Total nulls: 1099
  • DQMHistoTests: Total successes: 4772110
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8202.257999999998 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 436.348 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): 169.730 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): 157.263 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): 5.046 KiB HLT/Filters
  • Checked 256 log files, 206 edm output root files, 59 DQM output files
  • TriggerResults: found differences in 12 / 57 workflows

@missirol
Copy link
Contributor Author

please test

The RelVals-INPUT errors are likely unrelated, but I prefer to rerun the tests.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e34336/31478/summary.html
COMMIT: 8e9ac48
CMSSW: CMSSW_13_0_X_2023-03-20-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41114/31478/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 93 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4775834
  • DQMHistoTests: Total failures: 2600
  • DQMHistoTests: Total nulls: 1099
  • DQMHistoTests: Total successes: 4772113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8202.257999999998 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 436.348 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): 169.730 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): 157.263 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0,... ): 5.046 KiB HLT/Filters
  • Checked 256 log files, 206 edm output root files, 59 DQM output files
  • TriggerResults: found differences in 12 / 57 workflows

@missirol
Copy link
Contributor Author

+hlt

  • changes in the outputs of PR tests are in line with updates to the HLT GRun menu, and the change in name of the fake HLT menus

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

missirol commented Mar 22, 2023

The parent PR was tested in CMSSW_13_1_X_2023-03-21-2300. The HLT-Validation tests failed because of a transient issue with file access, see #41113 (comment). I don't see issues caused by that PR in that IB.

I think it's okay to merge this backport.

Edit: for the record, the HLT-Validation tests passed later on in CMSSW_13_1_X_2023-03-22-1100, which confirms the above guess.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 619a0dc into cms-sw:CMSSW_13_0_X Mar 22, 2023
@missirol missirol deleted the HLTdevelopment130X branch March 23, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants