Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading for cscofflinemonitor 2 #4112

Merged
merged 2 commits into from Jun 12, 2014

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Jun 4, 2014

I think I finally have the multithreading interface added to CSCOfflineMonitor in DQMOffline/Muon, for 72X. It also has some fixes for postls1 compatibility.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2014

A new Pull Request was created by @ptcox for CMSSW_7_2_X.

Multithreading for cscofflinemonitor 2

It involves the following packages:

DQMOffline/Muon

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2014

@deguio
Copy link
Contributor

deguio commented Jun 12, 2014

hello @ptcox
this PR is ok for me, thanks. could you comment about how the efficiency histograms are handled now?

cheers,
F.

@ptcox
Copy link
Contributor Author

ptcox commented Jun 12, 2014

Hi Federico,

I haven’t done anything about calculating the efficiencies yet. I was hoping to be able to use DQMGenericClient but I haven’t started working on it. (Since the efficiencies in the old code were broken anyway, we are no worse off now than we were before, and when I find time I’ll try to get the calculation working properly.)

Regards, Tim

On Jun 12, 2014, at 17:13 , deguio notifications@github.com wrote:

hello @ptcox
this PR is ok for me, thanks. could you comment about how the efficiency histograms are handled now?

cheers,
F.


Reply to this email directly or view it on GitHub.

@deguio
Copy link
Contributor

deguio commented Jun 12, 2014

+1
thanks for the clarification.
cheers,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 12, 2014
…tor_2

Multithreading for CSCOfflineMonitor
@ktf ktf merged commit 3a838b9 into cms-sw:CMSSW_7_2_X Jun 12, 2014
@rociovilar
Copy link
Contributor

+1
rocio
On 04 Jun 2014, at 19:42, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

A new Pull Request was created by @ptcoxhttps://github.com/ptcox for CMSSW_7_2_X.

Multithreading for cscofflinemonitor 2

It involves the following packages:

DQMOffline/Muon

@ojedahttps://github.com/ojeda, @dandugganhttps://github.com/danduggan, @roverehttps://github.com/rovere, @cmsbuildhttps://github.com/cmsbuild, @nclopezohttps://github.com/nclopezo, @deguiohttps://github.com/deguio, @deganohttps://github.com/degano can you please review it and eventually sign? Thanks.
@barvichttps://github.com/barvic, @rociovilarhttps://github.com/rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4112#issuecomment-45124629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants