Remove the const_cast from SiStripFedCablingFakeESSource

[tvami]

PR description:

The SA reported that the

/CalibTracker/SiStripESProducers/plugins/fake/SiStripFedCablingFakeESSource.cc
has a const_cast which is not thread safe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-480837/31402/llvm-analysis/report-69c66f.html#EndPath

This PR (by Marco) resolves that.

PR validation:

Payload produced by SiStripFedCablingBuilder_cfg.py has the same content as before the PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no backport is needed.

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41121/34760

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CalibTracker/SiStripESProducers (alca)

@tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please abort

[mmusich]

test parameters:

• addpkg = CondTools/SiStrip

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6f013/31493/summary.html
COMMIT: 3ea00a5
CMSSW: CMSSW_13_1_X_2023-03-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41121/31493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550915
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550883
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• SA is happy now: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6f013/31493/llvm-analysis/

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1